New features #10

cuihantao · 2025-01-04T21:53:13Z

Features:

Support uploading BibTex and formatting the publication section accordingly.
Added a theme selector and added my theme.
Added the support for meta.pageSize for letter and A4, but no UI changes have been made.

Fixes

Time formatted will recognize "now" and "present".
Fetch the remote schema first and use the local one as the fallback.

To do:

Please add LICENSE to the repository. Consider Apache or MIT.
Themes may be licensed in CC-BY or similar licenses.
Use citation.js or bibhtml to support custom citation formats.

… JSON, and Upload of BibTex accepts .bib and .txt.

…ore author names.

…in preview for the paper size (but won't print).

Citation format works correctly.

… for publications to include new fields (authors, citationKey, bibtexEntry) and improved handling of formatted citations. Modified BibTeX processing to support replace/merge modes for publications. Adjusted citation formatting in the UI to ensure proper display and alignment. Cleaned up CSS for citation layout.

…lication year if not available, and implemented sorting of publications by release date (newest first) in the CV data. Improved debug logging for better visibility of publication updates.

reorx · 2025-07-26T03:26:08Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces new features like BibTeX support and theme selection. The review focuses on correctness, maintainability, and robustness, identifying issues such as incorrect citation numbering, inefficient BibTeX handling, and external dependencies. Addressing these will improve reliability and maintainability.

gemini-code-assist · 2025-07-26T03:27:50Z

src/lib/bibtex.js

+    const publications = cite.data.map((entry, index) => {
+      console.log(`[Debug] Entry ${index} type:`, entry.type)
+
+      // Format individual citation
+      const singleCite = new Cite(entry)
+      const formattedHTML = singleCite.format('bibliography', {
+        format: 'html',
+        template: 'ieee',
+        lang: 'en-US'
+      })
+
+      // Clean up the HTML structure
+      const processedHTML = formattedHTML
+        .replace(/\r?\n|\r/g, '') // Remove all newlines
+        .replace(/>\s+</g, '><')  // Remove whitespace between tags
+        .replace(/\s+/g, ' ')     // Replace multiple spaces with single space
+        .replace(/, doi: .*?(?=<\/div>)/g, '')  // Remove DOI from citation text
+        .trim()                   // Remove leading/trailing whitespace


The current implementation generates formattedHTML incorrectly, resulting in all citations being numbered as [1]. Instead, use the citationDivs variable, which already contains the correctly formatted and numbered entries from the initial bibliography formatting.

const processedHTML = citationDivs[index] || '';

gemini-code-assist · 2025-07-26T03:27:50Z

src/themes/cuiv/index.ejs

+  // Group publications by type, defaulting to 'other' if type not specified
+  const journalPubs = cv.publications?.filter(p => p.type === 'journal') || []
+  const conferencePubs = cv.publications?.filter(p => p.type === 'conference') || []
+  const otherPubs = cv.publications?.filter(p => !p.type || p.type === 'other') || []
+
+  // Only show section if there are publications
+  if (hasItems(journalPubs) || hasItems(conferencePubs) || hasItems(otherPubs)) { 
+  %>
+  <section class="publications-section">
+    <div class="section-title">
+      <h2>Publications</h2>
+      <div class="line"></div>
+    </div>
+
+    <% if (hasItems(journalPubs)) { %>
+      <div class="subsection">
+        <h3>Journal Papers</h3>
+        <% for (let i = 0; i < journalPubs.length; i++) { %>
+          <div class="publication section-item">
+            <div class="citation"><%- formatCitation(journalPubs[i], i) %></div>
+            <%- linkInDiv(journalPubs[i].url) %>
+          </div>
+        <% } %>
+      </div>
+    <% } %>
+
+    <% if (hasItems(conferencePubs)) { %>
+      <div class="subsection">
+        <h3>Conference Papers</h3>
+        <% for (let i = 0; i < conferencePubs.length; i++) { %>
+          <div class="publication section-item">
+            <div class="citation"><%- formatCitation(conferencePubs[i], i) %></div>
+            <%- linkInDiv(conferencePubs[i].url) %>
+          </div>
+        <% } %>
+      </div>
+    <% } %>
+
+    <% if (hasItems(otherPubs)) { %>
+      <div class="subsection">
+        <h3>Other Publications</h3>
+        <% for (let i = 0; i < otherPubs.length; i++) { %>
+          <div class="publication section-item">
+            <div class="citation"><%- formatCitation(otherPubs[i], i) %></div>
+            <%- linkInDiv(otherPubs[i].url) %>
+          </div>
+        <% } %>
+      </div>
+    <% } %>
+  </section>
+  <% } %>


The logic for rendering publications resets the index i for each publication type, leading to incorrect citation numbers. Render publications in a single loop to maintain continuous numbering, adding subheadings conditionally within the loop.

gemini-code-assist · 2025-07-26T03:27:50Z

src/editor/main.js

+      const publications = await processBibTeX(bibtexStr, currentData)
+
+      // Get current mode from radio buttons
+      const shouldReplace = $('input[name="bibtex-mode"]:checked').val() === 'replace'
+      const newData = updatePublications(currentData, publications, shouldReplace)


The BibTeX processing logic is inefficient. processBibTeX is called, and its result is stored in publications. Then, updatePublications calls processBibTeX again. Simplify to a single call to processBibTeX with the correct shouldReplace parameter. The updatePublications function is then redundant and can be removed from src/lib/bibtex.js.

Suggested change

const publications = await processBibTeX(bibtexStr, currentData)

// Get current mode from radio buttons

const shouldReplace = $('input[name="bibtex-mode"]:checked').val() === 'replace'

const newData = updatePublications(currentData, publications, shouldReplace)

const shouldReplace = $('input[name="bibtex-mode"]:checked').val() === 'replace';

const newData = await processBibTeX(bibtexStr, currentData, shouldReplace);

gemini-code-assist · 2025-07-26T03:27:50Z

src/lib/bibtex.js

+import { plugins } from '@citation-js/core'
+
+// Fetch and register IEEE CSL template
+fetch('https://raw.githubusercontent.com/citation-style-language/styles/master/ieee.csl')


Fetching the IEEE CSL template from a remote URL introduces an external dependency that could cause the application to fail if the URL is unavailable or changes. Consider including the ieee.csl file directly in the repository and loading it locally for better reliability.

gemini-code-assist · 2025-07-26T03:27:50Z

src/lib/bibtex.js

+function _parsePublication(pub) {
+  if (typeof pub === 'string') {
+    try {
+      return JSON.parse(pub)
+    } catch (e) {
+      console.error('Failed to parse publication:', e)
+      return pub
+    }
+  }
+  return pub
+}


The function _parsePublication is defined but unused. Remove it to improve code clarity.

gemini-code-assist · 2025-07-26T03:27:50Z

src/editor/main.js

+  const keyFormatMap = {
+    // Basic fields
+    'basics.properties.summary': 'textarea',

-// add format to schema
-const keyFormatMap = {
-  'basics.properties.summary': 'textarea',
-  'work.items.properties.description': 'textarea',
-  'work.items.properties.summary': 'textarea',
-  'work.items.properties.highlights.items': 'textarea',
-  'projects.items.properties.description': 'textarea',
-  'projects.items.properties.highlights.items': 'textarea',
-  'sideProjects.items.properties.description': 'textarea',
-  'skills.items.properties.summary': 'textarea',
-  'languages.items.properties.summary': 'textarea',
-  'references.items.properties.reference': 'textarea',
-  'awards.items.properties.summary': 'textarea',
-  'publications.items.properties.summary': 'textarea',
-  'volunteer.items.properties.summary': 'textarea',
-  'volunteer.items.properties.highlights.items': 'textarea',
-}
-for (const [key, format] of Object.entries(keyFormatMap)) {
-  objectPath.get(jsoncvSchema.properties, key).format = format
-}
+    // Work and projects
+    'work.items.properties': {
+      'description': 'textarea',
+      'summary': 'textarea',
+      'highlights.items': 'textarea'
+    },
+    'projects.items.properties': {
+      'description': 'textarea',
+      'highlights.items': 'textarea'
+    },
+    'sideProjects.items.properties.description': 'textarea',
+
+    // Skills and qualifications
+    'skills.items.properties.summary': 'textarea',
+    'languages.items.properties.summary': 'textarea',
+    'references.items.properties.reference': 'textarea',
+
+    // Awards and recognition
+    'awards.items.properties.summary': 'textarea',
+    'publications.items.properties.summary': 'textarea',
+    'volunteer.items.properties': {
+      'summary': 'textarea',
+      'highlights.items': 'textarea'
+    },

-// change schema title
-jsoncvSchema.title = 'CV Schema'
+    // Academic fields
+    'researchAreas.items.properties': {
+      'description': 'textarea',
+      'contributions.items': 'textarea'
+    },
+    'academicAppointments.items.properties.summary': 'textarea',
+    'teaching.items.properties.description': 'textarea',
+    'grants.items.properties.summary': 'textarea',
+    'mentoring.items.properties.summary': 'textarea',
+    'professionalServices.items.properties.details': 'textarea',
+    'presentations.items.properties.description': 'textarea',
+    'software.items.properties.description': 'textarea'
+  }


The keyFormatMap object uses a mix of direct string values and nested objects, adding complexity. Flatten the structure for better readability and maintainability by using dot-separated keys for all entries.

cuihantao added 23 commits January 4, 2025 14:34

Working feature to upload BibTex.

45225b8

Group BibTex menu in the UI.

22e6ac2

Restrict file types to avoid accidental mistakes. Upload Data accepts…

c394355

… JSON, and Upload of BibTex accepts .bib and .txt.

Fix a bug where author names go to highlight. Extend the schema to st…

f989a10

…ore author names.

Fix width of preview to remove horizontal scroll bar.

949fa71

Add the option in meta to choose from A4 and letter. Add indicator …

e33cdbf

…in preview for the paper size (but won't print).

Store colorPrimary and theme to schema.

5fc3609

Editor supports picking theme. Added new theme cuiv

27390f2

Update to new theme.

4530df0

Refactor the sidebar; fetch remote schema and use local as fall back.

79359db

Clean up console logs.

7ca9456

Fix publication section to work with the current schema.

f261c6d

Make string date formatter recognize "now" and "present".

94985e2

Fix publication year to display the year only.

54e1658

Fix author names in publication list.

496bb07

Fix author list and format publication venue.

e7ca661

Format citations for publications from JSON and uploaded bib.

b6d6886

Citation format works correctly.

Bib loading working again, but IEEE template not taking effect.

ff8e689

WIP using IEEE CSL.

c2669b2

Enhance BibTeX processing: Added fallback for release date to use pub…

16215e5

…lication year if not available, and implemented sorting of publications by release date (newest first) in the CV data. Improved debug logging for better visibility of publication updates.

Add back pageSize and theme in meta.

0cf2991

Add dark mode for cuiv theme.

0a52e9d

gemini-code-assist bot reviewed Jul 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

New features #10

New features #10

Uh oh!

cuihantao commented Jan 4, 2025

Uh oh!

reorx commented Jul 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

Uh oh!

Uh oh!

New features #10

Are you sure you want to change the base?

New features #10

Uh oh!

Conversation

cuihantao commented Jan 4, 2025

Uh oh!

reorx commented Jul 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!