Skip to content

fix: hanged Apple Login view #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ignaciosantise merged 2 commits into from
May 29, 2025
Merged

fix: hanged Apple Login view #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279cb47
fix: solved issue with apple login on iOS
ignaciosantise May 21, 2025
bfba655
Merge branch 'develop' into fix/apple-login
ignaciosantise May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .changeset/soft-waves-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
'@reown/appkit-scaffold-react-native': patch
'@reown/appkit-ethers5-react-native': patch
'@reown/appkit-ethers-react-native': patch
'@reown/appkit-wagmi-react-native': patch
'@reown/appkit-auth-ethers-react-native': patch
'@reown/appkit-auth-wagmi-react-native': patch
'@reown/appkit-coinbase-ethers-react-native': patch
'@reown/appkit-coinbase-wagmi-react-native': patch
'@reown/appkit-common-react-native': patch
'@reown/appkit-core-react-native': patch
'@reown/appkit-scaffold-utils-react-native': patch
'@reown/appkit-siwe-react-native': patch
'@reown/appkit-ui-react-native': patch
'@reown/appkit-wallet-react-native': patch
---

fix: solved issue with apple login on iOS
8 changes: 2 additions & 6 deletions packages/scaffold/src/views/w3m-connecting-social-view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useSnapshot } from 'valtio';
import { useCallback, useEffect, useState } from 'react';
import { Platform } from 'react-native';
import {
ConnectionController,
ConnectorController,
Expand Down Expand Up @@ -35,12 +34,9 @@ export function ConnectingSocialView() {
const { uri } = await provider.getSocialRedirectUri({
provider: ConnectionController.state.selectedSocialProvider
});
WebviewController.setWebviewUrl(uri);

const isNativeApple =
ConnectionController.state.selectedSocialProvider === 'apple' && Platform.OS === 'ios';

WebviewController.setWebviewVisible(!isNativeApple);
WebviewController.setWebviewUrl(uri);
WebviewController.setWebviewVisible(true);
WebviewController.setConnecting(true);
WebviewController.setConnectingProvider(ConnectionController.state.selectedSocialProvider);
}
Expand Down
Loading