You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved wallet search to filter out non-walletconnect and walletconnect wallets based on platform and SDK type
Type of change
Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Associated Issues
For Linear issues: Closes APKT-2635
Checklist
Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link
Note
Filters wallet list and search results by WalletConnect support based on platform/SDK, adds supports_wc field and Binance connector, and updates tests.
Scaffold UI:
w3m-all-wallets-list and w3m-all-wallets-search now use WalletUtil.filterWalletsByWcSupport(...) to filter displayed wallets.
Mobile shows WC-supported (plus mandatory IDs); AppKit Core (desktop) shows WC-supported only; full AppKit (desktop) shows all.
Utils:
Add WalletUtil.filterWalletsByWcSupport with platform-aware rules and MANDATORY_WALLET_IDS_ON_MOBILE.
Add Binance support: ConstantsUtil.BINANCE_CONNECTOR_NAME and PresetsUtil.ConnectorExplorerIds[BINANCE_CONNECTOR_NAME].
Controllers:
Extend WcWallet with optional supports_wc.
Tests:
Add unit tests for WC-based filtering in WalletUtil and UI list/search components.
Written by Cursor Bugbot for commit ad6b1f9. This will update automatically on new commits. Configure here.
@reown/appkit - Main Entry
Size limit: 80 kB
Size: 73.44 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 457 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit/react
Size limit: 230 kB
Size: 227.16 kB with all dependencies, minified and gzipped
Loading time: 4.5 s on slow 3G
Running time: 968 ms on Snapdragon 410
Total time: 5.5 s
@reown/appkit/vue
Size limit: 80 kB
Size: 73.44 kB with all dependencies, minified and gzipped
Loading time: 1.5 s on slow 3G
Running time: 385 ms on Snapdragon 410
Total time: 1.9 s
@reown/appkit-scaffold-ui
Size limit: 220 kB
Size: 207.91 kB with all dependencies, minified and gzipped
Loading time: 4.1 s on slow 3G
Running time: 672 ms on Snapdragon 410
Total time: 4.8 s
@reown/appkit-ui
Size limit: 500 kB
Size: 13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms on slow 3G
Running time: 72 ms on Snapdragon 410
Total time: 329 ms
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved wallet search to filter out non-walletconnect and walletconnect wallets based on platform and SDK type
Type of change
Associated Issues
For Linear issues: Closes APKT-2635
Checklist
Note
Filters wallet list and search results by WalletConnect support based on platform/SDK, adds
supports_wcfield and Binance connector, and updates tests.w3m-all-wallets-listandw3m-all-wallets-searchnow useWalletUtil.filterWalletsByWcSupport(...)to filter displayed wallets.WalletUtil.filterWalletsByWcSupportwith platform-aware rules andMANDATORY_WALLET_IDS_ON_MOBILE.ConstantsUtil.BINANCE_CONNECTOR_NAMEandPresetsUtil.ConnectorExplorerIds[BINANCE_CONNECTOR_NAME].WcWalletwith optionalsupports_wc.WalletUtiland UI list/search components.Written by Cursor Bugbot for commit ad6b1f9. This will update automatically on new commits. Configure here.