Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Description

Fixes console logging behavior in AlertController.open() method where configuration notices were being logged as errors (console.error()) regardless of the alert variant type, and were appearing in production when they should only show in development/debug mode.

Changes:

  • Console logging now only occurs when debug mode is enabled via OptionsController.state.debug
  • Console method is now selected based on the variant parameter:
    • 'error'console.error()
    • 'warning'console.warn()
    • 'info' and 'success'console.log()

This ensures "[Reown Config Notice]" messages (which use 'warning' variant) now use console.warn() instead of console.error(), reducing noise in production environments.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Fixes WCPBX-58

Human Review Checklist

  • Verify the behavioral change (console logging now requires debug: true) is acceptable for your use case
  • Confirm no existing monitoring systems depend on the previous console.error() output

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Link to Devin run: https://app.devin.ai/sessions/1fc40bc882d8422faa7457a1736cff99
Requested by: [email protected] ([email protected])

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@linear
Copy link

linear bot commented Dec 23, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: e9308de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Dec 23, 2025 2:09pm
appkit-demo Ready Ready Preview, Comment Dec 23, 2025 2:09pm
appkit-gallery Ready Ready Preview, Comment Dec 23, 2025 2:09pm
appkit-headless-sample-app Ready Ready Preview, Comment Dec 23, 2025 2:09pm
appkit-laboratory Ready Ready Preview, Comment Dec 23, 2025 2:09pm
10 Skipped Deployments
Project Deployment Review Updated (UTC)
appkit-basic-example Ignored Ignored Dec 23, 2025 2:09pm
appkit-basic-sign-client-example Ignored Ignored Dec 23, 2025 2:09pm
appkit-basic-up-example Ignored Ignored Dec 23, 2025 2:09pm
appkit-ethers5-bera Ignored Ignored Dec 23, 2025 2:09pm
appkit-nansen-demo Ignored Ignored Dec 23, 2025 2:09pm
appkit-vue-solana Ignored Ignored Dec 23, 2025 2:09pm
appkit-wagmi-cdn-example Ignored Ignored Dec 23, 2025 2:09pm
ethereum-provider-wagmi-example Ignored Ignored Dec 23, 2025 2:09pm
next-wagmi-solana-bitcoin-example Ignored Ignored Dec 23, 2025 2:09pm
vue-wagmi-example Ignored Ignored Dec 23, 2025 2:09pm

@github-actions
Copy link
Contributor

Visual Regression Test Results ✅ Passed

⚠️ 6 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=529
Storybook Preview: https://6493191bf4b10fed8ca7353f-fkxhlksroc.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions
Copy link
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit


[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         73.95 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 571 ms   on Snapdragon 410
Total time:   2.1 s
@reown/appkit/react
Size limit:   230 kB
Size:         229.23 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 1.2 s     on Snapdragon 410
Total time:   5.7 s
@reown/appkit/vue
Size limit:   80 kB
Size:         73.95 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 455 ms   on Snapdragon 410
Total time:   1.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.34 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 576 ms    on Snapdragon 410
Total time:   4.7 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 50 ms    on Snapdragon 410
Total time:   307 ms

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.78% 38442 / 48181
🔵 Statements 79.78% 38442 / 48181
🔵 Functions 77.25% 4113 / 5324
🔵 Branches 86.53% 9339 / 10792
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/AlertController.ts 85.45% 100% 57.14% 85.45% 58, 62, 69-75
Generated in workflow #16555 for commit e9308de by the Vitest Coverage Report Action

@enesozturk enesozturk closed this Dec 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants