-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: use appropriate console methods based on alert variant and only log in debug mode #5420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…log in debug mode Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=529 👉 Please review the visual changes in Chromatic and accept or reject them. |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit [baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Fixes console logging behavior in
AlertController.open()method where configuration notices were being logged as errors (console.error()) regardless of the alert variant type, and were appearing in production when they should only show in development/debug mode.Changes:
debugmode is enabled viaOptionsController.state.debugvariantparameter:'error'→console.error()'warning'→console.warn()'info'and'success'→console.log()This ensures "[Reown Config Notice]" messages (which use 'warning' variant) now use
console.warn()instead ofconsole.error(), reducing noise in production environments.Type of change
Associated Issues
Fixes WCPBX-58
Human Review Checklist
debug: true) is acceptable for your use caseconsole.error()outputChecklist
Link to Devin run: https://app.devin.ai/sessions/1fc40bc882d8422faa7457a1736cff99
Requested by: [email protected] ([email protected])