-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: use appropriate console methods and development-only logging in AlertController #5422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use appropriate console methods and development-only logging in AlertController #5422
Conversation
…AlertController - Use console.error for 'error' variant - Use console.warn for 'warning' variant - Use console.info for 'info' and 'success' variants - Only log to console in development mode using CommonConstantsUtil.IS_DEVELOPMENT - Add comprehensive tests for the new console logging behavior WCPBX-58 Co-Authored-By: [email protected] <[email protected]>
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=531 👉 Please review the visual changes in Chromatic and accept or reject them. |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit [baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
…errors Co-Authored-By: [email protected] <[email protected]>
Description
Fixes console logging behavior in
AlertController.open()to use appropriate console methods based on alert variant type and only log in development environments.Previously, all debug messages used
console.error()regardless of variant type and appeared in production environments. This caused the "[Reown Config Notice]" warning messages to show as errors in production console (including laboratory app previews).Changes:
console.error()for 'error' variantconsole.warn()for 'warning' variantconsole.info()for 'info' and 'success' variantsCommonConstantsUtil.IS_DEVELOPMENT)The visual alert bar behavior remains unchanged - only console logging is affected.
Type of change
Associated Issues
Closes WCPBX-58
Human Review Checklist
returninside theif (debugMessage)block doesn't skip any expected behavior (displayMessage handling occurs before this block)IS_DEVELOPMENTcheck correctly identifies development vs production environmentsChecklist
Link to Devin run: https://app.devin.ai/sessions/94c70afb907248afb6f152d312a63f30
Requested by: [email protected] ([email protected])