Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 24, 2025

Description

Fixes console logging behavior in AlertController.open() to use appropriate console methods based on alert variant type and only log in development environments.

Previously, all debug messages used console.error() regardless of variant type and appeared in production environments. This caused the "[Reown Config Notice]" warning messages to show as errors in production console (including laboratory app previews).

Changes:

  • Use console.error() for 'error' variant
  • Use console.warn() for 'warning' variant
  • Use console.info() for 'info' and 'success' variants
  • Skip console logging entirely when not in development mode (using CommonConstantsUtil.IS_DEVELOPMENT)

The visual alert bar behavior remains unchanged - only console logging is affected.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes WCPBX-58

Human Review Checklist

  • Verify the early return inside the if (debugMessage) block doesn't skip any expected behavior (displayMessage handling occurs before this block)
  • Confirm IS_DEVELOPMENT check correctly identifies development vs production environments

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Link to Devin run: https://app.devin.ai/sessions/94c70afb907248afb6f152d312a63f30
Requested by: [email protected] ([email protected])

…AlertController

- Use console.error for 'error' variant
- Use console.warn for 'warning' variant
- Use console.info for 'info' and 'success' variants
- Only log to console in development mode using CommonConstantsUtil.IS_DEVELOPMENT
- Add comprehensive tests for the new console logging behavior

WCPBX-58

Co-Authored-By: [email protected] <[email protected]>
@linear
Copy link

linear bot commented Dec 24, 2025

@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: 673df98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Dec 24, 2025 2:23pm
appkit-demo Error Error Dec 24, 2025 2:23pm
appkit-gallery Ready Ready Preview, Comment Dec 24, 2025 2:23pm
appkit-headless-sample-app Ready Ready Preview, Comment Dec 24, 2025 2:23pm
appkit-laboratory Ready Ready Preview, Comment Dec 24, 2025 2:23pm
10 Skipped Deployments
Project Deployment Review Updated (UTC)
appkit-basic-example Ignored Ignored Dec 24, 2025 2:23pm
appkit-basic-sign-client-example Ignored Ignored Dec 24, 2025 2:23pm
appkit-basic-up-example Ignored Ignored Dec 24, 2025 2:23pm
appkit-ethers5-bera Ignored Ignored Dec 24, 2025 2:23pm
appkit-nansen-demo Ignored Ignored Dec 24, 2025 2:23pm
appkit-vue-solana Ignored Ignored Dec 24, 2025 2:23pm
appkit-wagmi-cdn-example Ignored Ignored Dec 24, 2025 2:23pm
ethereum-provider-wagmi-example Ignored Ignored Dec 24, 2025 2:23pm
next-wagmi-solana-bitcoin-example Ignored Ignored Dec 24, 2025 2:23pm
vue-wagmi-example Ignored Ignored Dec 24, 2025 2:23pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Visual Regression Test Results ✅ Passed

⚠️ 6 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=531
Storybook Preview: https://6493191bf4b10fed8ca7353f-kcgfiqblwi.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Warnings
⚠️

🌐 Non-company domain introduced (host: dashboard.reown.com.) in packages/controllers/tests/controllers/AlertController.test.ts (line 81): https://dashboard.reown.com.

Generated by 🚫 dangerJS against 673df98

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit


[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         73.96 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 303 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         229.24 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 643 ms    on Snapdragon 410
Total time:   5.2 s
@reown/appkit/vue
Size limit:   80 kB
Size:         73.96 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 320 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.35 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 473 ms    on Snapdragon 410
Total time:   4.6 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 70 ms    on Snapdragon 410
Total time:   326 ms

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.78% 38440 / 48181
🔵 Statements 79.78% 38440 / 48181
🔵 Functions 77.23% 4112 / 5324
🔵 Branches 86.55% 9347 / 10799
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/AlertController.ts 83.63% 100% 57.14% 83.63% 59, 62, 65, 72-78
Generated in workflow #16557 for commit 673df98 by the Vitest Coverage Report Action

@enesozturk enesozturk added this pull request to the merge queue Dec 25, 2025
Merged via the queue into main with commit 23bb47b Dec 25, 2025
62 of 64 checks passed
@enesozturk enesozturk deleted the devin/1766585056-fix-alert-controller-console-logging branch December 25, 2025 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants