Skip to content

Conversation

@0xmkh
Copy link
Collaborator

@0xmkh 0xmkh commented Jan 7, 2026

Description

Added unsubscribe function to AppKit event listeners

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-4318

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

🦋 Changeset detected

Latest commit: bdf5f77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@reown/appkit Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-ton Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Jan 7, 2026 8:25am
appkit-demo Ready Ready Preview, Comment Jan 7, 2026 8:25am
appkit-gallery Ready Ready Preview, Comment Jan 7, 2026 8:25am
appkit-headless-sample-app Ready Ready Preview, Comment Jan 7, 2026 8:25am
appkit-laboratory Ready Ready Preview, Comment Jan 7, 2026 8:25am
10 Skipped Deployments
Project Deployment Review Updated (UTC)
appkit-basic-example Ignored Ignored Jan 7, 2026 8:25am
appkit-basic-sign-client-example Ignored Ignored Jan 7, 2026 8:25am
appkit-basic-up-example Ignored Ignored Jan 7, 2026 8:25am
appkit-ethers5-bera Ignored Ignored Jan 7, 2026 8:25am
appkit-nansen-demo Ignored Ignored Jan 7, 2026 8:25am
appkit-vue-solana Ignored Ignored Jan 7, 2026 8:25am
appkit-wagmi-cdn-example Ignored Ignored Jan 7, 2026 8:25am
ethereum-provider-wagmi-example Ignored Ignored Jan 7, 2026 8:25am
next-wagmi-solana-bitcoin-example Ignored Ignored Jan 7, 2026 8:25am
vue-wagmi-example Ignored Ignored Jan 7, 2026 8:25am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Thank you for your contribution! We ask that you please read and sign our CTA Document before we can accept your contribution. You can sign the CTA simply by posting a Pull Request Comment with the following text:


I have read the CTA Document and I hereby sign the CTA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@0xmkh 0xmkh changed the title chore: add unsubscribe function to appkit listeners chore: add unsubscribe functions to appkit listeners Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Visual Regression Test Results ✅ Passed

⚠️ 7 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=577
Storybook Preview: https://6493191bf4b10fed8ca7353f-uxorgcbjng.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit


[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.01 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 615 ms   on Snapdragon 410
Total time:   2.1 s
@reown/appkit/react
Size limit:   235 kB
Size:         233.03 kB with all dependencies, minified and gzipped
Loading time: 4.6 s     on slow 3G
Running time: 1.2 s     on Snapdragon 410
Total time:   5.8 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.01 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 428 ms   on Snapdragon 410
Total time:   1.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         212.49 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 614 ms    on Snapdragon 410
Total time:   4.8 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 143 ms   on Snapdragon 410
Total time:   400 ms

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.58% 39348 / 50072
🔵 Statements 78.58% 39348 / 50072
🔵 Functions 76.3% 4238 / 5554
🔵 Branches 86.76% 9563 / 11022
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 73.08% 85.58% 76.69% 73.08% 183-189, 209, 222-225, 228, 240-241, 247-248, 251, 260, 307-308, 354-355, 393-394, 396-397, 402-403, 483-484, 520-526, 597-598, 620-635, 638, 672-673, 676, 717-721, 728-729, 732-733, 738-739, 750-773, 782-783, 800-820, 824-845, 848-874, 877-883, 886-892, 895-901, 904-910, 913-923, 926-932, 935-942, 956-965, 968-974, 977-978, 981-982, 1001-1002, 1025-1065, 1072-1084, 1090-1117, 1120-1130, 1162-1163, 1188-1189, 1194, 1209-1225, 1239, 1243-1251, 1282-1283, 1302-1305, 1309-1310, 1312-1313, 1347-1349, 1353-1374, 1379-1380, 1388-1389, 1391-1392, 1486-1487, 1499-1500, 1505, 1528-1533, 1580, 1601-1602, 1611, 1613-1629, 1634, 1680-1681, 1693-1704, 1750-1763, 1808, 1814-1818, 1839-1854, 1857-1858, 1884-1887, 1923-1942, 1974, 2017-2018, 2024-2050, 2271-2272, 2309-2310, 2313-2314, 2330-2333, 2336-2337, 2357-2358, 2361-2362, 2383, 2404-2405, 2408-2415, 2419-2420, 2434, 2442, 2461-2462, 2468-2469, 2500-2505, 2523-2524, 2527-2528, 2575-2576, 2647-2648, 2651-2652, 2655-2658, 2661-2662, 2665-2666, 2669-2670, 2673-2674, 2677-2681, 2690-2699, 2708-2719, 1372
Generated in workflow #16613 for commit bdf5f77 by the Vitest Coverage Report Action

@0xmkh 0xmkh merged commit 05762b5 into main Jan 7, 2026
43 of 44 checks passed
@0xmkh 0xmkh deleted the chore/add-unsub branch January 7, 2026 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants