Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Get config from self after build_config()#14

Open
mibes wants to merge 1 commit intoreown-com:masterfrom
mibes:master
Open

Get config from self after build_config()#14
mibes wants to merge 1 commit intoreown-com:masterfrom
mibes:master

Conversation

@mibes
Copy link

@mibes mibes commented Nov 5, 2022

Description

build_config() mutates self. This pull request ensures that the config is cloned from self after build_config() is called.

Resolves #13

How Has This Been Tested?

Used the forked code in production, and confirmed that this is now working as expected.

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@vhawley
Copy link

vhawley commented Jan 5, 2023

I am unaffiliated with this project, but I have tested this change and confirm it works as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unwrap of a None value when config is not set

2 participants