fix(apns): handling of the certificate expiration error

[geekbrother]

Description

This PR adds proper handling of the received fatal alert: CertificateExpired APNS error.

How Has This Been Tested?

Not tested.

Due Diligence

• Breaking change
• Requires a documentation update
• Requires a e2e/integration test update

[geekbrother]

Fixing clippy error.

[zthrigger]

Fix

[Copilot]

Pull Request Overview

This PR introduces handling for APNS CertificateExpired errors and simplifies public IP lookup.

• Simplify public_ip assignment by using .ok()
• Add a new match arm for CertificateExpired in the APNS provider

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/state.rs	Replace manual match with .ok() for public IP
src/providers/apns.rs	Add explicit handling for CertificateExpired alerts

Comments suppressed due to low confidence (3)

src/providers/apns.rs:178

• [nitpick] Using dbg as a variable name can be confused with the dbg! macro. Rename this binding to something more descriptive, like debug_msg.

dbg if dbg.contains("received fatal alert: CertificateExpired") => {

src/providers/apns.rs:175

• New error variant ApnsCertificateExpired is introduced but there are no tests for this branch. Consider adding a unit test that simulates the CertificateExpired response.

impl PushProvider for ApnsProvider {

src/providers/apns.rs:179

• The client_error identifier isn't in scope here and named placeholders aren't supported by info!. You likely need to reference the correct error variable and use {} formatting with positional arguments.

info!("APNs certificate expired: debug:{dbg}, display: {client_error}");