chore: remove unused google-services-file from POS workflows#360
Merged
ignaciosantise merged 1 commit intomainfrom Jan 26, 2026
Merged
chore: remove unused google-services-file from POS workflows#360ignaciosantise merged 1 commit intomainfrom
ignaciosantise merged 1 commit intomainfrom
Conversation
The google-services-file secret was being passed to release-ios-base.yaml but that workflow never declared or used this secret, making it dead code. Remove from both pos-app and poc-pos-app iOS release configurations. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 38s —— View job Review Complete
✅ No issues found Verified:
|
There was a problem hiding this comment.
Pull request overview
Removes unused Google services-related secrets from the POS iOS release workflows now that the base iOS workflow does not declare or consume them.
Changes:
- Removed the
POS_IOS_GOOGLE_SERVICES_FILE_BASE64secret forwarding from.github/workflows/release-pos.yaml. - Removed the
POC_POS_IOS_GOOGLE_SERVICES_FILE_BASE64secret forwarding from.github/workflows/release-pos-poc.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release-pos.yaml | Stops passing an undeclared/unused google-services-file secret into the base iOS workflow for the POS app. |
| .github/workflows/release-pos-poc.yaml | Stops passing an undeclared/unused google-services-file secret into the base iOS workflow for the POC POS app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused
google-services-filesecrets from the iOS release workflows for both pos-app and poc-pos-app. These secrets were being passed to the base iOS workflow but were never declared or used there, making them dead code that could be safely removed.Changes
POS_IOS_GOOGLE_SERVICES_FILE_BASE64from.github/workflows/release-pos.yamlPOC_POS_IOS_GOOGLE_SERVICES_FILE_BASE64from.github/workflows/release-pos-poc.yamlTest Plan