fix(pos-app): load default partner API key on first install

[ignaciosantise]

Problem

On first app install, the default partner API key was not preloaded. Users had to manually navigate to Settings, clear the merchant ID, and save to trigger the default values. Additionally, after resetting to defaults, the Partner API Key field appeared empty until navigating away and back.

Root Causes

1. Race condition: clearStaleSecureStorage() in _layout.tsx was running after onRehydrateStorage had already saved the default API key, deleting it immediately
2. State mismatch: After clearMerchantId saved a new API key, the useMerchantFlow hook's local state wasn't refreshed because the useEffect dependency was stable

Solution

• Moved clearStaleSecureStorage() to run at the start of onRehydrateStorage (before defaults are set)
• Added isMerchantApiKeySet as a dependency to the API key loading effect to trigger state refresh after changes

Changes

• store/useSettingsStore.ts: Call clearStaleSecureStorage() at start of hydration
• app/_layout.tsx: Remove the now-redundant clearStaleSecureStorage() call
• hooks/use-merchant-flow.ts: Add dependency to refresh API key state on store updates

Testing

• Fresh install: merchant ID and partner API key should both load from env defaults
• Payment creation should work immediately without manual settings adjustment
• Settings reset: Partner API Key field should show masked value immediately

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
react-native-examples	Ready	Preview, Comment	Feb 5, 2026 3:44pm

[claude]

Claude finished @ignaciosantise's task in 1m 3s —— View job

---

Code Review

Tasks:

• Read modified files for full context
• Analyze race condition fix
• Analyze state management fix
• Check for issues
• Provide feedback

---

✅ No issues found

Analysis Summary:

Race condition fix (lines 303-305 in useSettingsStore.ts):

• clearStaleSecureStorage() now runs at start of onRehydrateStorage before defaults are set
• Prevents deletion of freshly-set default API key on first install
• Correctly clears stale secure storage only when app_has_launched flag is false

State refresh fix (line 78 in use-merchant-flow.ts):

• Added isMerchantApiKeySet to useEffect dependency array
• Ensures storedMerchantApiKey local state refreshes after clearMerchantId updates the store
• Previously, stable getMerchantApiKey reference prevented re-run after store changes

Code removal (_layout.tsx lines 71-74 removed):

• Redundant clearStaleSecureStorage() call removed since it now runs during hydration
• Prevents duplicate execution and potential timing issues

All changes correctly address the reported issues. Logic is sound, no edge cases identified.

---

[Copilot]

Pull request overview

This PR fixes two critical issues that prevented the default partner API key from being properly loaded on first app install: a race condition where stale storage clearing happened after default values were set, and a state synchronization issue where the UI didn't refresh after resetting credentials.

Changes:

• Fixed race condition by moving clearStaleSecureStorage() to execute at the start of store hydration, before default values are written
• Added isMerchantApiKeySet as a dependency to trigger API key state refresh in the merchant flow hook
• Removed redundant clearStaleSecureStorage() call from _layout.tsx

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
dapps/pos-app/store/useSettingsStore.ts	Moved clearStaleSecureStorage() to run at the start of onRehydrateStorage callback to execute before default values are set
dapps/pos-app/hooks/use-merchant-flow.ts	Added isMerchantApiKeySet as a useEffect dependency to refresh local API key state when store updates
dapps/pos-app/app/_layout.tsx	Removed duplicate clearStaleSecureStorage() call that was causing the race condition

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.