Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for decoding an updated Topic ID format while retaining legacy topic IDs within relay_rpc’s domain types.
Changes:
- Introduces
TopicDecodingErrorand new decoding logic forDecodedTopicsupporting legacy and “pairing” topic kinds (withRegionextraction). - Refactors hex encoding/decoding into shared helpers and reuses them in existing byte-array newtypes.
- Expands unit tests to cover pairing topic decoding and region validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mario-reown
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new Relay-side generated topic ID format (18 bytes) that encodes the use-case (WCP/non-WCP) and Relay region.
How Has This Been Tested?
Unit
Due Diligence