fix: use erc6492 lib and remove dedicated ERC-1271 verification logic #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
fix/use-6492-lib
branch
from
69c8288 to
628b3e3
Compare
chris13524
force-pushed
the
fix/use-6492-lib
branch
from
afc56aa to
1ff884f
Compare
geekbrother
approved these changes
Apr 29, 2024
chris13524
force-pushed
the
fix/use-6492-lib
branch
from
8f369ee to
c4bb4b2
Compare
chris13524
force-pushed
the
fix/use-6492-lib
branch
from
0fde622 to
eb8fbc3
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the ERC-6492 and ERC-1271 logic into the dedicated erc6492 library. Removes all the Foundry logic and unnecessary dependencies.
EOA verification remains as it was already written and it saves on an RPC request. This dedicated case likely only works due to old SDK versions who didn't support ERC-6492 anyway.
Also updates
GetProviderto accept aProviderrather than aUrl. UpdatesBlockchainApiProviderto re-use the reqwest client for all invocations.Remaining work:
How Has This Been Tested?
Existing tests
Due Diligence