Skip to content

🐛 Use startsWith for the wc:// check in the UriService #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexV525 wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

🐛 Use startsWith for the wc:// check in the UriService #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/reown_appkit/lib/modal/services/uri_service/url_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class UriService extends IUriService {
}

// If the wallet is just a generic wc:// then it is not installed
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says this only filters out a "generic wc://", but the new condition returns false for any URI that starts with wc:// (including wc://<something>). Update the comment to match the actual behavior (e.g., clarify that any WalletConnect wc:// scheme is treated as not-installed).

Suggested change
// If the wallet is just a generic wc:// then it is not installed
// Treat any WalletConnect wc:// scheme URI as not installed

Copilot uses AI. Check for mistakes.
if (uri.contains('wc://')) {
if (uri.startsWith('wc://')) {
return false;
}
Comment on lines +20 to 22
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes installation-detection behavior; please add a unit test covering both cases: wc://... returns false, while custom schemes that merely contain wc:// later in the string (e.g. demowc://) are not incorrectly rejected. This will prevent regressions of issue #329.

Copilot uses AI. Check for mistakes.

Expand Down
Loading