Skip to content

adding error router to rescue in event processing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamenger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding error router to rescue in event processing #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/fluent/plugin/in_beats.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def run
rescue => e
log.error "unexpected error", :error => e.to_s
log.error_backtrace
router.emit_error_event(tag, time, record, e)
Copy link
Owner

@repeatedly repeatedly Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

record may be nil when user doesn't specify parser. Need to check record / map value.
In addition, need option to emit error event because emit event in this point is sometimes not useful, e.g. hard to recover broken value.

Copy link
Author

@adamenger adamenger Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would we be checking or comparing the record/map value to? Could you give me a quick example of how we could check this accurately?

You make a good point about the config option and not always emitting errors. I'll see if I can add that code for the config quickly.

Thanks for your feedback!

end
}
end
Expand Down