feat(api): handle config item "when" attribute (#2450)

* feat(api): filter config disabled

* f

* f

Author: emosbaugh

api/controllers/kubernetes/install/app.go

@@ -15,10 +15,14 @@ func (c *InstallController) GetAppConfig(ctx context.Context) (kotsv1beta1.Confi
 		return kotsv1beta1.Config{}, errors.New("app config not found")
 	}
 
-	return *c.releaseData.AppConfig, nil
+	return c.appConfigManager.GetConfig(*c.releaseData.AppConfig)
 }
 
 func (c *InstallController) SetAppConfigValues(ctx context.Context, values map[string]string) (finalErr error) {
+	if c.releaseData == nil || c.releaseData.AppConfig == nil {
+		return errors.New("app config not found")
+	}
+
 	lock, err := c.stateMachine.AcquireLock()
 	if err != nil {
 		return types.NewConflictError(err)
@@ -47,7 +51,7 @@ func (c *InstallController) SetAppConfigValues(ctx context.Context, values map[s
 		}
 	}()
 
-	err = c.appConfigManager.SetConfigValues(ctx, values)
+	err = c.appConfigManager.SetConfigValues(*c.releaseData.AppConfig, values)
 	if err != nil {
 		return fmt.Errorf("set app config values: %w", err)
 	}

api/controllers/kubernetes/install/controller_mock.go

@@ -57,9 +57,6 @@ func (m *MockController) GetInfra(ctx context.Context) (types.Infra, error) {
 // GetAppConfig mocks the GetAppConfig method
 func (m *MockController) GetAppConfig(ctx context.Context) (kotsv1beta1.Config, error) {
 	args := m.Called(ctx)
-	if args.Get(0) == nil {
-		return kotsv1beta1.Config{}, args.Error(1)
-	}
 	return args.Get(0).(kotsv1beta1.Config), args.Error(1)
 }
 

api/controllers/linux/install/app.go

@@ -15,10 +15,14 @@ func (c *InstallController) GetAppConfig(ctx context.Context) (kotsv1beta1.Confi
 		return kotsv1beta1.Config{}, errors.New("app config not found")
 	}
 
-	return *c.releaseData.AppConfig, nil
+	return c.appConfigManager.GetConfig(*c.releaseData.AppConfig)
 }
 
 func (c *InstallController) SetAppConfigValues(ctx context.Context, values map[string]string) (finalErr error) {
+	if c.releaseData == nil || c.releaseData.AppConfig == nil {
+		return errors.New("app config not found")
+	}
+
 	lock, err := c.stateMachine.AcquireLock()
 	if err != nil {
 		return types.NewConflictError(err)
@@ -47,7 +51,7 @@ func (c *InstallController) SetAppConfigValues(ctx context.Context, values map[s
 		}
 	}()
 
-	err = c.appConfigManager.SetConfigValues(ctx, values)
+	err = c.appConfigManager.SetConfigValues(*c.releaseData.AppConfig, values)
 	if err != nil {
 		return fmt.Errorf("set app config values: %w", err)
 	}

api/controllers/linux/install/controller_mock.go

@@ -90,9 +90,6 @@ func (m *MockController) GetInfra(ctx context.Context) (types.Infra, error) {
 // GetAppConfig mocks the GetAppConfig method
 func (m *MockController) GetAppConfig(ctx context.Context) (kotsv1beta1.Config, error) {
 	args := m.Called(ctx)
-	if args.Get(0) == nil {
-		return kotsv1beta1.Config{}, args.Error(1)
-	}
 	return args.Get(0).(kotsv1beta1.Config), args.Error(1)
 }
 

api/internal/managers/app/config/config.go

@@ -1,13 +1,76 @@
 package config
 
 import (
-	"context"
+	"fmt"
+
+	kotsv1beta1 "github.com/replicatedhq/kotskinds/apis/kots/v1beta1"
+	"github.com/replicatedhq/kotskinds/multitype"
+	"github.com/tiendc/go-deepcopy"
 )
 
+func (m *appConfigManager) GetConfig(config kotsv1beta1.Config) (kotsv1beta1.Config, error) {
+	return filterAppConfig(config)
+}
+
 func (m *appConfigManager) GetConfigValues() (map[string]string, error) {
 	return m.appConfigStore.GetConfigValues()
 }
 
-func (m *appConfigManager) SetConfigValues(ctx context.Context, values map[string]string) error {
-	return m.appConfigStore.SetConfigValues(values)
+func (m *appConfigManager) SetConfigValues(config kotsv1beta1.Config, configValues map[string]string) error {
+	filteredValues := make(map[string]string)
+
+	// only include values for enabled groups and items
+	for _, g := range config.Spec.Groups {
+		for _, i := range g.Items {
+			if isItemEnabled(g.When) && isItemEnabled(i.When) {
+				value, ok := configValues[i.Name]
+				if ok {
+					filteredValues[i.Name] = value
+				}
+				for _, c := range i.Items {
+					value, ok := configValues[c.Name]
+					if ok {
+						filteredValues[c.Name] = value
+					}
+				}
+			}
+		}
+	}
+
+	return m.appConfigStore.SetConfigValues(filteredValues)
+}
+
+// filterAppConfig filters out disabled groups and items based on their 'when' condition
+func filterAppConfig(config kotsv1beta1.Config) (kotsv1beta1.Config, error) {
+	// deepcopy the config to avoid mutating the original config
+	var updatedConfig kotsv1beta1.Config
+	if err := deepcopy.Copy(&updatedConfig, &config); err != nil {
+		return kotsv1beta1.Config{}, fmt.Errorf("deepcopy: %w", err)
+	}
+
+	filteredGroups := make([]kotsv1beta1.ConfigGroup, 0)
+
+	for _, group := range config.Spec.Groups {
+		if !isItemEnabled(group.When) {
+			continue
+		}
+		filteredItems := make([]kotsv1beta1.ConfigItem, 0)
+		for _, item := range group.Items {
+			if !isItemEnabled(item.When) {
+				continue
+			}
+			filteredItems = append(filteredItems, item)
+		}
+		if len(filteredItems) > 0 {
+			group.Items = filteredItems
+			filteredGroups = append(filteredGroups, group)
+		}
+	}
+	updatedConfig.Spec.Groups = filteredGroups
+	return updatedConfig, nil
+}
+
+// isItemEnabled checks if an item is enabled based on its 'when' condition
+func isItemEnabled(when multitype.QuotedBool) bool {
+	return when != "false"
 }