Skip to content

Conversation

@ajp-io
Copy link
Member

@ajp-io ajp-io commented Mar 24, 2025

What this PR does / why we need it:

Warn that you shouldn't join another node when a controller is being joined.

Also update other warns to use logrus.Warn.

Screenshot 2025-03-24 at 2 44 41 PM

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/106755/warn-that-you-should-only-join-one-node-at-a-time

Does this PR require a test?

NONE

Does this PR require a release note?

When joining a controller node, warn that the user shouldn't join another node until the controller joins successfully.

Does this PR require documentation?

replicatedhq/replicated-docs#3126

@github-actions
Copy link

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-e3ed978" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-e3ed978?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@emosbaugh
Copy link
Member

emosbaugh commented Mar 24, 2025

Failures are unrelated to changes. Merging

@emosbaugh emosbaugh merged commit 49d3d5b into main Mar 24, 2025
58 of 66 checks passed
@emosbaugh emosbaugh deleted the alexparker/sc-106755/warn-that-you-should-only-join-one-node-at branch March 24, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants