-
Notifications
You must be signed in to change notification settings - Fork 99
Add customer ID to the license #5702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| endpoint: https://example.com | ||
| customerID: customer-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
| endpoint: https://example.com | |
| customerID: customer-id | |
| endpoint: https://example.com | |
| customerID: customer-id |
| Endpoint: "https://example.com", | ||
| CustomerID: "customer-id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would this pass with wrong indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or does yaml parse just not care about tabs vs spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't :), was trying to figure out why it's failing. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah!
What this PR does / why we need it:
Adds the customer ID to the license so that vendors can then send it from on-prem instances back to their envs.
Which issue(s) this PR fixes:
SC-131529
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONe