Implement (external) logs/describe/details via fileserver for velero cli - fixes #12 #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to download the velero logs, describe backups and show details via an ingress / external access. Fixing #12
For this new (optional) plugin configurations are offered
Not setting those will default to the old behavior instructing the velero cli to download the logs using the internal pod ip of the fileserver (which always fails).
When providing those, including
examples/fileserverService
)www.velero-logs.domain.com
You will be able to download the velero logs when running
velero backup logs manual1
.You can test it yourself by using my test image
ghcr.io/eugenmayer/local-volume-provider:0.7.3
Known limitations
it seems like the velero cli is not able to download the logs from a TLS ingress (official signed LE certificate). it always fails with.
Assuming this is a velero limitation right now, created an issue vmware-tanzu/velero#8677