Add examples directory to Mlflow chart #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottrigby
reviewed
May 5, 2025
Contributor
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
I think this is great! We can always add more/refine later too. Some suggestions and a question for ya as well
| nginx.ingress.kubernetes.io/ssl-redirect: "false" | ||
| tls: | ||
| enabled: true | ||
| genSelfSignedCert: true = |
Contributor
There was a problem hiding this comment.
typo fix
Suggested change
| genSelfSignedCert: true = | |
| genSelfSignedCert: true |
| protocol: https | ||
| host: "s3.amazonaws.com" | ||
| port: 443 | ||
| ignoreTls: false No newline at end of file |
Contributor
There was a problem hiding this comment.
needs newline at EOF
Suggested change
| ignoreTls: false | |
| ignoreTls: false | |
| mlflow: | ||
| backendStore: | ||
| # Use an existing secret containing the database connection string | ||
| existingSecret: "mlflow-postgres-secret" No newline at end of file |
Contributor
There was a problem hiding this comment.
needs newline at EOF
Suggested change
| existingSecret: "mlflow-postgres-secret" | |
| existingSecret: "mlflow-postgres-secret" | |
| -f ./charts/mlflow/examples/database/embedded/values.yaml \ | ||
| -f ./charts/mlflow/examples/network/ingress/values.yaml | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
@diamonwiggins I know we discussed on Slack the idea of adding comments about sensitive values to the main values.yaml, and I agree it's not the best place for it.
But since we're informing folks how to do this by example here, what do you think about taking the opportunity to ensure they follow our example securely? What do you think about something like this?
Suggested change
| Be sure that files containing unencrypted sensitive values are never committed to Git. To address this, you can use tools like Sealed Secrets or SOPS to encrypt the values in the file. Or avoid adding these to values files altogether by using `--set` on the command line, which can be combined with the above techniques: | |
| ```bash | |
| helm install mlflow ./charts/mlflow \ | |
| -f examples/database/external/direct-credentials.yaml \ | |
| --set postgres.auth.username=foo \ | |
| --set postgres.auth.password=bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.