Skip to content

Conversation

@pandemicsyn
Copy link
Contributor

@pandemicsyn pandemicsyn commented Oct 29, 2024

@pandemicsyn pandemicsyn added type::feature type::docs Improvements or additions to documentation labels Oct 29, 2024
@netlify
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit 54475d2
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs-upgrade/deploys/672274cc66754e0008bfabc8
😎 Deploy Preview https://deploy-preview-2791--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit 54475d2
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs/deploys/672274cc82825f0009d6be6f
😎 Deploy Preview https://deploy-preview-2791--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

grantmiller
grantmiller previously approved these changes Oct 29, 2024
@pandemicsyn pandemicsyn marked this pull request as ready for review October 29, 2024 18:55
@pandemicsyn pandemicsyn requested a review from a team as a code owner October 29, 2024 18:55

Connecting the Replicated proxy registry with Harbor and Artifactory has the following limitations:

* Neither the catalog or tags listing endpoints respect pagination requests yet but harbor requests 1000 items at a time. (Documented in "Harbor _catalog use": https://docs.google.com/document/d/1Ece7PaFOV12EVhMWFMHkrVZLDHFQfWUv4rWzi_wRjAM/edit#heading=h.wxiwuxpqb3pw)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paigecalvert thats our internal google doc. The harbor page size isn't documented anymore other than code - so not sure its worth linking too since it could change at any time.

But https://github.com/goharbor/harbor/blob/9e55afbb9a124dbe47562d56769ad4e9f14cb5ed/src/pkg/registry/client.go#L705 is the permalink for the current harbor version where this is set.


* Neither the catalog or tags listing endpoints exposed by the Replicated proxy service respect pagination requests. However, Harbor requests 1000 items at a time.

* Only authenticated users can perform catalog calls or list tags. Authenticated users are those with an email address and license ID associated with a customer in the Vendor Portal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authenticated users are those with an email address and license ID associated with a customer in the Vendor Portal.

Just put this down as a guess. Not sure if it's worth clarifying what we mean by "authenticated user"


1. (Optional) Add a pull-based replication rule to support image mirroring. See [Configure Image Mirroring in Harbor](#harbor-mirror) below.

### Configure Image Mirroring in Harbor {#harbor-mirror}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Moved this to its own subsection

@@ -0,0 +1,72 @@
# Using a Registry Proxy for Helm Air Gap Installations (Alpha)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left "for Helm Air Gap Installations" in the title since it sounds like that is the main use case this is intending to server for now. I figure we could always expand and move this topic as the scope of likely use cases grows, but lmk if that makes sense to you

On that note, not sure if "Alpha" is an appropriate label here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think its fine, our main Helm Air Gap doc flags as being alpha too and this is probably also just the first pass for this bit (hence things like us not respecting pagination requests yet).

@pandemicsyn pandemicsyn merged commit c5e62d3 into main Oct 30, 2024
5 checks passed
@pandemicsyn pandemicsyn deleted the florianhines/sc-114300/download-portal-should-allow-enterprises branch October 30, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants