-
Notifications
You must be signed in to change notification settings - Fork 31
Update Replicated CLI docs for v0.88.1 #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| items: [ | ||
| 'reference/replicated-cli-installing', | ||
| // This list is generated. Do not edit. | ||
| 'reference/replicated', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ The description in this new overview topic is not great
Manage your Commercial Software Distribution Lifecycle using Replicated
Synopsis
The 'replicated' CLI allows Replicated customers (vendors) to manage their Commercial Software Distribution Lifecycle (CSDL) using the Replicated API.
We probably don't need much of a definition of the CLI TBH, but something like "the CLI for the Vendor Portal" would prob suffice
| @@ -0,0 +1,52 @@ | |||
| # replicated app rm | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ could be helpful to list delete as an alias?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ same goes for channel rm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function right now does not add aliases to the output: https://github.com/spf13/cobra/blob/6c3c1163c6df19860515103199e880122ba49e80/doc/md_docs.go#L57-L117
Which is inconsistent with Go template they use for rendering help on command line: https://github.com/spf13/cobra/blob/6c3c1163c6df19860515103199e880122ba49e80/command.go#L558-L559
We can fix that.
|
|
||
| ### Synopsis | ||
|
|
||
| Enable semantic versioning for the CHANNEL_ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable semantic versioning for the CHANNEL_ID.
I think this would be better as "Enable semantic versioning for the channel.", rather than CHANNEL_ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment for disable-semver above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once doc generating PR is merged, this can be addressed
| Create a new application in your Replicated account. | ||
|
|
||
| This command allows you to initialize a new application that can be distributed | ||
| and managed using the KOTS platform. When you create a new app, it will be set up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...application that can be distributed
and managed using the KOTS platform. ...
^ not sure what the KOTS platform means here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once doc generating PR is merged, this can be addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Paige to add redirect for this page to app rm in the netlify toml before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
| @@ -1,22 +0,0 @@ | |||
| import Help from "../partials/replicated-cli/_help.mdx" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ looks like each of the completion topics got deleted in favor of a single completion topic that lists bash, fish, powershell, zsh as options
I'm fine with this as long as there wasn't anything that you all think it would be helpful to go into more detail about in individual topics for each option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Will close this PR once all comments are resolved. Changes to address content comments need to be made in the Replicated CLI project. |
|
Closing. The updated cli docs were added with #2987 |

No description provided.