Skip to content

Conversation

@divolgin
Copy link
Member

No description provided.

@divolgin divolgin requested a review from a team as a code owner January 21, 2025 20:23
@replicated-ci replicated-ci added type::docs Improvements or additions to documentation type::feature labels Jan 21, 2025
@netlify
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit d396625
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs/deploys/6790025c6d67d00008bbe0b2
😎 Deploy Preview https://deploy-preview-2984--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit d396625
🔍 Latest deploy log https://app.netlify.com/sites/replicated-docs-upgrade/deploys/6790025cb1ee2300088daa74
😎 Deploy Preview https://deploy-preview-2984--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

items: [
'reference/replicated-cli-installing',
// This list is generated. Do not edit.
'reference/replicated',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ The description in this new overview topic is not great

Manage your Commercial Software Distribution Lifecycle using Replicated

Synopsis

The 'replicated' CLI allows Replicated customers (vendors) to manage their Commercial Software Distribution Lifecycle (CSDL) using the Replicated API.

We probably don't need much of a definition of the CLI TBH, but something like "the CLI for the Vendor Portal" would prob suffice

@@ -0,0 +1,52 @@
# replicated app rm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ could be helpful to list delete as an alias?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ same goes for channel rm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function right now does not add aliases to the output: https://github.com/spf13/cobra/blob/6c3c1163c6df19860515103199e880122ba49e80/doc/md_docs.go#L57-L117

Which is inconsistent with Go template they use for rendering help on command line: https://github.com/spf13/cobra/blob/6c3c1163c6df19860515103199e880122ba49e80/command.go#L558-L559

We can fix that.


### Synopsis

Enable semantic versioning for the CHANNEL_ID.
Copy link
Contributor

@paigecalvert paigecalvert Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable semantic versioning for the CHANNEL_ID.

I think this would be better as "Enable semantic versioning for the channel.", rather than CHANNEL_ID

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment for disable-semver above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once doc generating PR is merged, this can be addressed

Create a new application in your Replicated account.

This command allows you to initialize a new application that can be distributed
and managed using the KOTS platform. When you create a new app, it will be set up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...application that can be distributed
and managed using the KOTS platform. ...

^ not sure what the KOTS platform means here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once doc generating PR is merged, this can be addressed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Paige to add redirect for this page to app rm in the netlify toml before merging

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@@ -1,22 +0,0 @@
import Help from "../partials/replicated-cli/_help.mdx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ looks like each of the completion topics got deleted in favor of a single completion topic that lists bash, fish, powershell, zsh as options

I'm fine with this as long as there wasn't anything that you all think it would be helpful to go into more detail about in individual topics for each option

Copy link
Member Author

@divolgin divolgin Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed... They will need to be defined as separate subcommands in order to be in separate topics, similar to registry add commands

Screenshot 2025-01-21 at 5 51 05 PM

@divolgin divolgin marked this pull request as draft January 22, 2025 01:26
@divolgin
Copy link
Member Author

Will close this PR once all comments are resolved. Changes to address content comments need to be made in the Replicated CLI project.

@paigecalvert
Copy link
Contributor

Closing. The updated cli docs were added with #2987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants