-
Notifications
You must be signed in to change notification settings - Fork 31
Update helm-image-registry.mdx #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i believe these are actually the correct ways to reference these
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| image: | ||
| # proxy.registry.com or your custom domain | ||
| registry: ghcr.io | ||
| repository: proxy/app/ghcr.io/cloudnative-pg/cloudnative-pg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs app or some placeholder for the app slug, because the proxy URL is always `/proxy/appslug/registry_stuff
crdant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was wrong, and once you adopt @ajp-io 's change it'll be good to go
paigecalvert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crdant @grantmiller I updated this with Alex's suggestion per Chuck's latest comment. Approving for merge if it looks good
i believe these are actually the correct ways to reference these