Skip to content

Conversation

@grantmiller
Copy link
Member

i believe these are actually the correct ways to reference these

i believe these are actually the correct ways to reference these
@grantmiller grantmiller requested a review from a team as a code owner June 12, 2025 23:55
@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit a05a839
🔍 Latest deploy log https://app.netlify.com/projects/replicated-docs/deploys/684c46d19d6da60008394cba
😎 Deploy Preview https://deploy-preview-3307--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit a05a839
🔍 Latest deploy log https://app.netlify.com/projects/replicated-docs-upgrade/deploys/684c46d13f54f40008d90fd2
😎 Deploy Preview https://deploy-preview-3307--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@replicated-ci replicated-ci added type::docs Improvements or additions to documentation type::feature labels Jun 12, 2025
image:
# proxy.registry.com or your custom domain
registry: ghcr.io
repository: proxy/app/ghcr.io/cloudnative-pg/cloudnative-pg
Copy link
Member

@ajp-io ajp-io Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs app or some placeholder for the app slug, because the proxy URL is always `/proxy/appslug/registry_stuff

paigecalvert
paigecalvert previously approved these changes Jun 13, 2025
Copy link
Member

@crdant crdant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was wrong, and once you adopt @ajp-io 's change it'll be good to go

Copy link
Contributor

@paigecalvert paigecalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crdant @grantmiller I updated this with Alex's suggestion per Chuck's latest comment. Approving for merge if it looks good

@ajp-io ajp-io merged commit 529985a into main Jun 13, 2025
5 checks passed
@ajp-io ajp-io deleted the grantmiller-patch-9 branch June 13, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants