Properly parse escaped string interpolation in multiline strings. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a is preceded with it is not treated as a string interpolation.
lhchavez
approved these changes
Jun 22, 2022
lhchavez
left a comment
lhchavez
left a comment
There was a problem hiding this comment.
huh, i was not expecting that escaping syntax.
| if (i > 1) input.acceptToken(indStrContent, -1); | ||
| else input.acceptToken(indStrEnd, 1); | ||
| break; | ||
| if (input.peek(1) === dollar) { |
There was a problem hiding this comment.
does this package have tests? it would be great to add a test case for this.
There was a problem hiding this comment.
i have tests in my lezer-parser-nix repo, but i changed token names, so the tests are outdated
(also my parser fails on attrpath interpolations like { a.${b}.${c} = 1; } ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
${}is preceded with''it is not treated as a string interpolation.Before:
After:
