Disable user mode install for pip #427
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
approved these changes
Feb 3, 2025
Collaborator
ryantm
left a comment
ryantm
left a comment
There was a problem hiding this comment.
approving, but @blast-hardcheese should probably take a look
blast-hardcheese
approved these changes
Feb 3, 2025
Contributor
blast-hardcheese
left a comment
blast-hardcheese
left a comment
There was a problem hiding this comment.
I think this is safe
Collaborator
Author
|
Oops this breaks pip installs from the shell. I am going to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In some cases, using user install mode for pip will break because with the uv setup we are running in a virtualenv, where user mode will be disabled.
What changed
If uv is already rolled out 100% we can consider switching this off. But we may break existing repls that aren't uv. If there's a way to do this only with uv repls, that'll be a better solution.