dynamically search with base nix store path #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#16 removed nix store paths from dynamic relinking, however some binaries have /nix/store paths paths that don't exists or are malformed. These should still be searched dynamically.
What changed
/nix/store/pkg-hash-version/libpath to the list of paths to dynamically check for valid libraries.Test plan
bunwhile havingpkgs.glibcinstalled doesn't failnumpyin a python repl worksRollout