Skip to content

Conversation

@vlinkz
Copy link
Contributor

@vlinkz vlinkz commented Jun 20, 2025

Why

#16 removed nix store paths from dynamic relinking, however some binaries have /nix/store paths paths that don't exists or are malformed. These should still be searched dynamically.

What changed

  • Instead of no longer trying to relink libraries set to /nix/store, simply add the base /nix/store/pkg-hash-version/lib path to the list of paths to dynamically check for valid libraries.

Test plan

  • Test that running bun while having pkgs.glibc installed doesn't fail
  • Test that installing and importing numpy in a python repl works

Rollout

  • This is fully backward and forward compatible

@vlinkz vlinkz requested review from airportyh and ryantm June 20, 2025 03:52
@vlinkz vlinkz force-pushed the vlinkz/dynamicnixsearch branch 2 times, most recently from 1c95c8b to 7005370 Compare June 20, 2025 04:11
@vlinkz vlinkz force-pushed the vlinkz/dynamicnixsearch branch from 7005370 to 8e06c13 Compare June 20, 2025 15:36
@vlinkz vlinkz merged commit e607278 into main Jun 20, 2025
1 check failed
@vlinkz vlinkz deleted the vlinkz/dynamicnixsearch branch June 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants