Skip to content

Conversation

@cbrewster
Copy link
Member

Why

Supercedes #110, we want to punt desingin interceptors until later.

We'd like to have tracing between client and server, this implements spans for the client side.

What changed

  • Add tracing spans for each procedure call
  • Add support for propagating the tracing context to the river server using the tracing field of the transport message
    • Ideally the trasnsport message wouldn't hardcode the tracing fields, but we'd need to fix that in the JS implementation

Test plan

  • Connect this up to our internal usage, we should see spans for river procedure calls

@cbrewster cbrewster requested a review from a team as a code owner November 21, 2024 21:38
@cbrewster cbrewster requested review from blast-hardcheese and removed request for a team November 21, 2024 21:38
@cbrewster
Copy link
Member Author

cbrewster commented Nov 21, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@cbrewster cbrewster force-pushed the 11-21-Add_opentelemetry_instrumentation branch from 177916d to 362279a Compare November 21, 2024 21:39
Copy link
Contributor

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, other than that 📈

@cbrewster cbrewster force-pushed the 11-21-Add_opentelemetry_instrumentation branch from 362279a to 7717461 Compare November 21, 2024 21:58
@cbrewster cbrewster force-pushed the 11-21-Add_opentelemetry_instrumentation branch from 7717461 to 47821bc Compare November 21, 2024 22:03
@cbrewster cbrewster enabled auto-merge (squash) November 21, 2024 22:04
@cbrewster cbrewster merged commit b3afe94 into main Nov 21, 2024
3 checks passed
@cbrewster cbrewster deleted the 11-21-Add_opentelemetry_instrumentation branch November 21, 2024 22:04
@blast-hardcheese blast-hardcheese added enhancement New feature or request minor Bump minor version labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Bump minor version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants