[chore] Remove type:ignore for field renames #150
Merged
+61
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…old-style value reflection
blast-hardcheese
force-pushed
the
dstewart/chore/avoid-type-ignore
branch
from
88dce48 to
0970f8f
Compare
jackyzha0
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We had one overly-broad
# type: ignoredue to using the old-style of pydantic field renaming. Switching to PEP593-Annotatedtypes, we can communicate the alias as well as the default value correctly.What changed
Simplified codegen
Added tests
Test plan
CI