[bug] Resolve session.close() races #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When switching over to
_terminating_taskbeing authoritative, both_closing_waiter's state got out of sync and we did not actually set_terminating_task, which ensuredNcallbacks toclose_session_callbackinstead of at most once.What changed
_terminating_task_closing_waiterTest plan
test_reconnectwas just a duplicate oftest_connect, converting that over to handle the racing close case.