Skip to content

Conversation

@jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Sep 24, 2025

Why

  File "/Users/jzhao/projects/ai-infra/.venv/lib/python3.12/site-packages/replit_river/codegen/client.py", line 408, in encode_type
    raise ValueError(f"What does it mean to have {_o2} here?")
                                                 ^^^^^
  File "/Users/jzhao/projects/ai-infra/.venv/lib/python3.12/site-packages/replit_river/codegen/typing.py", line 33, in __str__
    raise Exception("Complex type must be put through render_type_expr!")
Exception: Complex type must be put through render_type_expr!

What changed

render the error correctly

Test plan

codegen doesnt crash

@jackyzha0 jackyzha0 requested a review from a team as a code owner September 24, 2025 23:14
@jackyzha0 jackyzha0 requested review from daweifeng-replit and removed request for a team September 24, 2025 23:14
@jackyzha0
Copy link
Member Author

theres a deeper problem here with nested datetypes in a recursive type lol, im just going to not codegen the offending proc for now

@jackyzha0 jackyzha0 closed this Sep 24, 2025
@jackyzha0 jackyzha0 changed the title LiteralType -> LiteralTypeExpr fix complex type repr Sep 24, 2025
@jackyzha0 jackyzha0 reopened this Sep 24, 2025
@jackyzha0 jackyzha0 merged commit dcec28b into main Sep 24, 2025
6 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/codegen-fix branch September 24, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants