rename session connect/disconnect -> created/closing/closed#288
Merged
rename session connect/disconnect -> created/closing/closed#288
Conversation
lhchavez
approved these changes
Feb 14, 2025
| "name": "@replit/river", | ||
| "description": "It's like tRPC but... with JSON Schema Support, duplex streaming and support for service multiplexing. Transport agnostic!", | ||
| "version": "0.204.0", | ||
| "version": "0.205.0", |
Contributor
There was a problem hiding this comment.
1️⃣ wen
if there's no good answer, let's do it on Apr 1 (pls also blogpost)
Member
Author
There was a problem hiding this comment.
yes i'd like to! faris thinks that we need more docs but tbd on what we still need there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nomenclature of 'connected'/'disconnected' is an artifact of when sessions were what connections are today, thats no longer accurate
this also allows us to disambiguate the 'about to close' state and 'already closed' state
these have two different cases:
What changed
Versioning