better validation errors, dont include all errors #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
requested review from
blast-hardcheese
and removed request for
a team
masad-frost
reviewed
Mar 21, 2025
| Type.Object({ | ||
| code: Type.Literal(INVALID_REQUEST_CODE), | ||
| message: Type.String(), | ||
| extras: Type.Optional( |
Member
There was a problem hiding this comment.
Maybe this is spicy, but how do we feel about keeping this a record instead of an object? Just feels like extras shouldn't necessarily have meaning.
Member
Author
There was a problem hiding this comment.
just for this type if u use it directly, in the union its absorbed by the record type
masad-frost
approved these changes
Mar 21, 2025
blast-hardcheese
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
previously, if you accidentally sent the wrong payload (e.g. mismatched service versions), you would get
expected requestData or control payloadwhich is a very unclear message given that you did providerequestData, its just wrongWhat changed
Versioning