fix sessionStatus type, remove no connection -> no connection transition on server, extra invariant checks #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection transition on server
jackyzha0
requested review from
Monkatraz and
masad-frost
and removed request for
a team
lhchavez
approved these changes
Mar 25, 2025
Contributor
lhchavez
left a comment
lhchavez
left a comment
There was a problem hiding this comment.
seems good to me, but you might benefit from another, more in-depth reviewer.
| "name": "@replit/river", | ||
| "description": "It's like tRPC but... with JSON Schema Support, duplex streaming and support for service multiplexing. Transport agnostic!", | ||
| "version": "0.205.1", | ||
| "version": "0.205.2", |
Contributor
There was a problem hiding this comment.
this feels a bit minory: some args of callbacks change.
Member
Author
There was a problem hiding this comment.
the interface change is backwards compatible (we passed the session field when the type didnt say it had a session field, now we declare a new id field which we do pass properly)
masad-frost
approved these changes
Mar 26, 2025
zhounathan
reviewed
Apr 4, 2025
| ); | ||
|
|
||
| oldSession = noConnectionSession; | ||
| this.updateSession(oldSession); |
Contributor
There was a problem hiding this comment.
are there any implications for moving this update up into the if block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
we get a very very low volume of message out of order (~40 messages across 15m connections) but these still suck
lets see if the message ordering problem is present before we send too
What changed
add some extra invariant violation checks before message send
fix some small session status type alignment and removed an extra state where we would emit an extra session transition for the transparent reconnect case
Versioning