Skip to content

make passive heartbeat case respond async #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackyzha0 merged 6 commits into from
Mar 28, 2025
Merged

make passive heartbeat case respond async #299

jackyzha0 merged 6 commits into from
Mar 28, 2025

Conversation

@jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Mar 28, 2025 •
edited
Loading

Why

  • we've traded all of our received out-of-order msg, closing connection for invariant violation: would have sent out of order msg
  • some browsers allow events to pre-empt / interrupt existing sync code which could cause problems

What changed

  • make the response wait a tick

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner March 28, 2025 17:51
@jackyzha0 jackyzha0 requested review from masad-frost and zhounathan and removed request for a team March 28, 2025 17:51
@jackyzha0 jackyzha0 force-pushed the jackyzha0/more-invariant-check-info branch from 80fb927 to d201d46 Compare March 28, 2025 18:12
@jackyzha0 jackyzha0 requested a review from Monkatraz March 28, 2025 19:06
@jackyzha0 jackyzha0 changed the title moar invariant checks make passive heartbeat case respond async Mar 28, 2025
@jackyzha0 jackyzha0 merged commit a211674 into main Mar 28, 2025
6 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/more-invariant-check-info branch March 28, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Monkatraz Monkatraz Monkatraz approved these changes

@zhounathan zhounathan Awaiting requested review from zhounathan zhounathan is a code owner automatically assigned from replit/agent-infrastructure

@masad-frost masad-frost Awaiting requested review from masad-frost

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyzha0 @Monkatraz