Skip to content

Switching over to workspace-infra #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blast-hardcheese merged 2 commits into from
Apr 15, 2025
Merged

Switching over to workspace-infra #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6084ca7
Typos
blast-hardcheese Apr 15, 2025
6af6541
Switching over to workspace-infra
blast-hardcheese Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @replit/workspace-infrastructure-and-editor
* @replit/workspace-infra
4 changes: 2 additions & 2 deletions PROTOCOL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ interface ControlHandshakeRequest {
nextExpectedSeq: number; // integer
nextSentSeq: number; // integer
};
metdata?: unknown;
metadata?: unknown;
}

interface ControlHandshakeResponse {
Expand Down Expand Up @@ -639,7 +639,7 @@ To detect these phantom disconnects, the server SHOULD send an explicit heartbea
This is because clients are usually browsers which means we cannot trust user-facing timers (due to various reasons like browser throttling, hibernation, etc.) so we rely purely on the server to track time.

This message is a `ControlAck` message.
The `seq` and `ack` of the message should match that of the session itself and otherwise be transmitted like a normal message (i.e. should stil increment bookkeeping like incrementing `seq`).
The `seq` and `ack` of the message should match that of the session itself and otherwise be transmitted like a normal message (i.e. should still increment bookkeeping like incrementing `seq`).

Clients SHOULD echo back a heartbeat in the same format as soon as it receives a server heartbeat.

Expand Down