Skip to content

Comments

Update Github Workflow#327

Merged
daweifeng-replit merged 6 commits intomainfrom
dawei/update-github-workflow
Jun 16, 2025
Merged

Update Github Workflow#327
daweifeng-replit merged 6 commits intomainfrom
dawei/update-github-workflow

Conversation

@daweifeng-replit
Copy link
Contributor

@daweifeng-replit daweifeng-replit commented Jun 16, 2025

Why

The previous release drafter and Build and upload package workflow did not work! In the previous setup, when we publish a draft release created by release drafter, it does not update the version in package.json so the package.json file in the released source code is outdated.

What changed

  • We still use release drafter like before. But instead of publishing the draft release directly, we should Go to Actions -> workflows/prepare-release.yml and run the workflow.
  • It will automatically create a git tag from the draft release
  • The new git tag will trigger the publish.yml workflow, which will build and publish the package to npm
  • Use node 22 in CI

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@daweifeng-replit daweifeng-replit requested a review from a team as a code owner June 16, 2025 21:07
@daweifeng-replit daweifeng-replit requested review from Monkatraz and removed request for a team June 16, 2025 21:07
@daweifeng-replit daweifeng-replit added bug Something isn't working patch Bug fixes, small improvements, or maintenance that don't change the API (e.g., 1.2.3 → 1.2.4) labels Jun 16, 2025
daweifeng-replit and others added 2 commits June 16, 2025 14:09
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is. Let me update it. It is also used in other workflow files.

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@daweifeng-replit daweifeng-replit merged commit de29abc into main Jun 16, 2025
9 checks passed
@daweifeng-replit daweifeng-replit deleted the dawei/update-github-workflow branch June 16, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Bug fixes, small improvements, or maintenance that don't change the API (e.g., 1.2.3 → 1.2.4)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants