Pass ParsedMetadata to SeviceSchema.scaffold()#330
Merged
daweifeng-replit merged 3 commits intomainfrom Jun 18, 2025
Merged
Conversation
daweifeng-replit
added
bug
daweifeng-replit
requested review from
jackyzha0 and
masad-frost
and removed request for
jackyzha0
masad-frost
reviewed
Jun 17, 2025
Member
masad-frost
left a comment
masad-frost
left a comment
There was a problem hiding this comment.
That's precisely why I think we should be passing around IMO, we wouldn't miss these things
masad-frost
approved these changes
Jun 17, 2025
Member
masad-frost
left a comment
masad-frost
left a comment
There was a problem hiding this comment.
Unblocking for now, but if you have a few minutes to refactor it would be nice
Contributor
Author
Agree! I will refactor it in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I should have pass
ParsedMetadatatoSeviceSchema.scaffold(). Otherwise, theServiceScaffoldalways setsParsedMetadataasobjectby defaultWhat changed
ParsedMetadatatoSeviceSchema.scaffold()Versioning