-
Notifications
You must be signed in to change notification settings - Fork 15
Release #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds attachment logging functionality to the Karate ReportPortal integration, enabling the embedding of binary attachments (like images) in test reports. The implementation adds support for Karate's karate.embed() function to send attachments to ReportPortal.
- Adds
embedAttachmentmethods to handle Karate embed objects - Integrates attachment handling into both Publisher and Hook execution flows
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/feature/embed.feature | Test feature demonstrating image attachment functionality |
| src/test/java/com/epam/reportportal/karate/utils/TestUtils.java | Adds utility method to extract binary parts from multipart requests |
| src/test/java/com/epam/reportportal/karate/logging/EmbedLoggingTest.java | Comprehensive test suite for attachment logging functionality |
| src/main/java/com/epam/reportportal/karate/ReportPortalUtils.java | Core utility method for embedding attachments to ReportPortal |
| src/main/java/com/epam/reportportal/karate/ReportPortalPublisher.java | Integrates attachment handling into the Publisher workflow |
| src/main/java/com/epam/reportportal/karate/ReportPortalHook.java | Integrates attachment handling into the Hook workflow with reflection |
| CHANGELOG.md | Documents the new attachment logging feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/java/com/epam/reportportal/karate/ReportPortalHook.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
No description provided.