Add option to create new aggregator based on a json file#68
Open
BrunoSegato13 wants to merge 3 commits intoreportportal:developfrom
Open
Add option to create new aggregator based on a json file#68BrunoSegato13 wants to merge 3 commits intoreportportal:developfrom
BrunoSegato13 wants to merge 3 commits intoreportportal:developfrom
Conversation
avarabyeu
requested changes
Nov 4, 2024
jsonFile/jsonFile.go
Outdated
| } | ||
|
|
||
| var nodesInfo map[string]*NodeInfo | ||
| if err := json.Unmarshal(byteValue, &nodesInfo); err != nil { |
Member
There was a problem hiding this comment.
it seems the be we are reading the whole file. In this case it could be as easy as
// read our opened jsonFile as a byte array.
byteValue, _ := ioutil.ReadAll(jsonFile)
var nodesInfo map[string]*NodeInfo
json.Unmarshal(byteValue, &nodesInfo)
docker-compose-caddy.yaml
Outdated
| @@ -0,0 +1,416 @@ | |||
| version: "3.8" | |||
Member
There was a problem hiding this comment.
i don't think we need to store yet another copy of compose file in this repo. Let's just get it removed
Member
|
As another option, you may want to consider using Caddy API to get actual list of services and their URLs |
BrunoSegato13
force-pushed
the
feature/json-file-aggregator
branch
from
f696d0b to
b4c4d8e
Compare
Author
|
Thank you for the suggestion to use the Caddy API to retrieve the URLs. I can implement it if you prefer, but I believe using a json file is simpler and more flexible, as it allows us to use others reverse proxies than Caddy/Traefik. |
BrunoSegato13
force-pushed
the
feature/json-file-aggregator
branch
from
10e0098 to
6c76abc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Due to some internal reasons, our company needs to deploy Report Portal with docker based using Caddy as reverse-proxy instead of Traefik.
With this change we faced the same issues mentioned in #43 where the redirection, versions information on login page and the health status for the analyzers services have stopped to work.
To address these issues, I have extend the service-index by adding the possibility to provide the services urls using a json file in oppose to be discovered by Traefik or k8s api, in this way at least for the installations where the services urls are not dynamically allocated we can use other reverse-proxy's besides Traefik without loosing any functionality.
Have also added one working example with the required changes to perform a deployment with Caddy.
If you find these changes beneficial for the service-index component, please consider review them.
Thank you!