Skip to content

Remove hardcoded width from Breadcrumbs #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yelyzavetakhokhlova merged 1 commit into from
Feb 25, 2026
Merged

Remove hardcoded width from Breadcrumbs #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .storybook/preview.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#storybook-root {
width: 100%;
max-width: 100%;
}

.sb-show-main.sb-main-centered #storybook-root {
width: 100%;
}
2 changes: 2 additions & 0 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import type { Preview } from '@storybook/react';

import './preview.css';

import ThemeProvider from '../src/components/themeProvider';

const preview: Preview = {
Expand Down
29 changes: 8 additions & 21 deletions src/components/breadcrumbs/breadcrumbs.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,32 @@
display: flex;
align-items: center;
gap: 16px;
width: 740px;
width: 100%;
}

.breadcrumbs {
flex-shrink: 1;
min-width: 0;
display: inline-flex;
display: flex;
align-items: center;
height: 100%;

.breadcrumb-item {
position: relative;
display: inline-flex;
display: flex;
align-items: center;
max-width: 100%;
@include font-scale();
Comment thread
yelyzavetakhokhlova marked this conversation as resolved.

&:not(.hidden-breadcrumbs) {
flex-shrink: 1;
flex: 1 1 auto;
min-width: 0;
}

&.hidden-breadcrumbs {
flex: 0 0 auto;
}

&:not(:last-child) {
padding-right: 24px;

Expand Down Expand Up @@ -53,21 +57,4 @@
}
}
}

&.breadcrumbs-2 .breadcrumb-item {
max-width: 360px;
}

&.breadcrumbs-3 .breadcrumb-item {
max-width: 233px;
}

&.breadcrumbs-4 .breadcrumb-item {
max-width: 170px;
}

&.breadcrumbs-5 .breadcrumb-item,
&.breadcrumbs-6-plus .breadcrumb-item {
max-width: 132px;
}
}
10 changes: 3 additions & 7 deletions src/components/breadcrumbs/breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,14 @@ export const Breadcrumbs = ({
isBackButton = false,
isLastClickable = false,
maxShownDescriptors = DEFAULT_MAX_SHOWN_DESCRIPTORS,
className,
}: BreadcrumbsProps) => {
const [firstDescriptor, ...remainingDescriptors] = descriptors;

const normalizedMaxShownDescriptors = Math.max(1, Math.floor(maxShownDescriptors));
const visibleTailCount = normalizedMaxShownDescriptors - 1;
const hiddenCount = Math.max(0, remainingDescriptors.length - visibleTailCount);

const getBreadcrumbsCountClass = (count: number): string => {
const suffix = count > 5 ? '6-plus' : count;
return `breadcrumbs-${suffix}`;
};

const titleTailNumChars = ((breadcrumbsCount: number) => {
const widths: Record<number, number> = {
1: 55,
Expand All @@ -51,7 +47,7 @@ export const Breadcrumbs = ({
return (
<BreadcrumbsProvider LinkComponent={LinkComponent}>
<div
className={cx('breadcrumbs-container')}
className={cx('breadcrumbs-container', className)}
data-automation-id={dataAutomationId}
data-testid={dataAutomationId}
>
Expand All @@ -68,7 +64,7 @@ export const Breadcrumbs = ({
<Tree tree={tree} />
</div>
)}
<div className={cx('breadcrumbs', getBreadcrumbsCountClass(descriptors.length))}>
<div className={cx('breadcrumbs')}>
{firstDescriptor && (
<div className={cx('breadcrumb-item')}>
<Breadcrumb
Expand Down
1 change: 1 addition & 0 deletions src/components/breadcrumbs/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ export interface BreadcrumbsProps {
isBackButton?: boolean;
isLastClickable?: boolean;
maxShownDescriptors?: number;
className?: string;
}
Loading