-
Notifications
You must be signed in to change notification settings - Fork 24
enhancement: Support SSL broker connections in worker #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.1.0dev
Are you sure you want to change the base?
enhancement: Support SSL broker connections in worker #750
Conversation
Signed-off-by: Srinjoy Dutta <[email protected]>
Signed-off-by: Srinjoy Dutta <[email protected]>
Signed-off-by: Srinjoy Dutta <[email protected]>
Hi @kairoaraujo, sorry for the oversight of not running the pre-commit checks. I have fixed them. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
============================================
- Coverage 100.00% 74.68% -25.32%
============================================
Files 15 14 -1
Lines 1071 1513 +442
============================================
+ Hits 1071 1130 +59
- Misses 0 383 +383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @srinjoydutta03
Things I would like to see in this PR:
- Documented the environment variables on
docs/source/guide/Docker_README.md
- Unit Tests for the changes in
tests/unit/test_app.py
As we are currently on RC state for 1.0.0, I will create a branch 1.1.0dev.
Signed-off-by: Srinjoy Dutta <[email protected]>
Hi @kairoaraujo I have added the tests and docs, along with a few minor changes in other files to make sure it all works as expected. |
"Fetch latest changes"
@kairoaraujo Could you please review them and tell me if any more changes are required? Thanks :) |
Description
Added support for SSL connections for broker/backend.
Related PR and Issue
This PR follows the changes made in the helm charts (repository-service-tuf/helm-charts#42).
Issue: #709
CC: @kairoaraujo