Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 31, 2025

🤔 What's changed?

  • Fixed incorrect binding language detection when reading reqnroll.json
  • Ensured language.binding takes priority over legacy bindingCulture format
  • Added comprehensive unit tests

⚡️ What's your motivation?

Setting the binding culture in reqnroll.json had two issues:

  1. It incorrectly set the feature language instead of the binding language
  2. The legacy bindingCulture format took priority over the newer language.binding format

User configuration that triggers the bug:

{
  "language": {
    "binding": "fr-FR"
  },
  "bindingCulture": {
    "name": "de-DE"
  }
}

Expected behavior:

  • Feature files remain in English
  • Step argument conversion uses French culture (fr-FR) for dates/numbers
  • New language.binding format should take priority over legacy bindingCulture

Actual behavior before fix:

  • Feature language got set to French, breaking English feature file parsing in Visual Studio
  • Legacy bindingCulture overwrote language.binding setting

Fixes #102

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Fix this issue reqnroll/Reqnroll.VisualStudio/issues/102. In th Reqnroll.VisualStudio repo. the specs are feature: The default language of feature files added to the project. We recommend using specific culture names (e.g.: en-US) rather than generi... Fix incorrect language assignment in ReqnrollConfigDeserializer causing binding culture to overwrite feature language Jul 31, 2025
Copilot AI requested a review from 304NotModified July 31, 2025 16:10
@304NotModified 304NotModified changed the title Fix incorrect language assignment in ReqnrollConfigDeserializer causing binding culture to overwrite feature language Fix incorrect reading of binding language Aug 4, 2025
@304NotModified 304NotModified marked this pull request as ready for review August 4, 2025 20:34
Copilot AI changed the title Fix incorrect reading of binding language Fix incorrect binding language detection and prioritization for Visual Studio extension Aug 5, 2025
Copilot AI requested a review from gasparnagy August 5, 2025 13:44
@304NotModified 304NotModified added the bug Something isn't working label Aug 9, 2025
Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@304NotModified 304NotModified merged commit a0c7adb into main Aug 10, 2025
2 checks passed
@gasparnagy gasparnagy deleted the copilot/fix-7936c092-4ee5-4ce0-ad7a-b14016a4aeb0 branch August 11, 2025 13:24
@gasparnagy
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect language used for binding

4 participants