-
Notifications
You must be signed in to change notification settings - Fork 11
Fix incorrect binding language detection and prioritization for Visual Studio extension #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
304NotModified
merged 4 commits into
main
from
copilot/fix-7936c092-4ee5-4ce0-ad7a-b14016a4aeb0
Aug 10, 2025
Merged
Fix incorrect binding language detection and prioritization for Visual Studio extension #104
304NotModified
merged 4 commits into
main
from
copilot/fix-7936c092-4ee5-4ce0-ad7a-b14016a4aeb0
Aug 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 304NotModified <[email protected]>
Copilot
AI
changed the title
[WIP] Fix this issue reqnroll/Reqnroll.VisualStudio/issues/102. In th Reqnroll.VisualStudio repo. the specs are
feature: The default language of feature files added to the project. We recommend using specific culture names (e.g.: en-US) rather than generi...
Fix incorrect language assignment in ReqnrollConfigDeserializer causing binding culture to overwrite feature language
Jul 31, 2025
304NotModified
approved these changes
Aug 4, 2025
gasparnagy
previously requested changes
Aug 5, 2025
Tests/Reqnroll.VisualStudio.Tests/Configuration/ReqnrollConfigDeserializerTests.cs
Show resolved
Hide resolved
…inding priority Co-authored-by: gasparnagy <[email protected]>
Copilot
AI
changed the title
Fix incorrect reading of binding language
Fix incorrect binding language detection and prioritization for Visual Studio extension
Aug 5, 2025
6 tasks
clrudolphi
approved these changes
Aug 10, 2025
Contributor
clrudolphi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
language.bindingtakes priority over legacybindingCultureformat⚡️ What's your motivation?
Setting the binding culture in
reqnroll.jsonhad two issues:bindingCultureformat took priority over the newerlanguage.bindingformatUser configuration that triggers the bug:
{ "language": { "binding": "fr-FR" }, "bindingCulture": { "name": "de-DE" } }Expected behavior:
language.bindingformat should take priority over legacybindingCultureActual behavior before fix:
bindingCultureoverwrotelanguage.bindingsettingFixes #102
🏷️ What kind of change is this?
📋 Checklist:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.