Fix indentation in generated step definition classes#144
Merged
304NotModified merged 4 commits intosupport-file-scoped-namespacesfrom Dec 16, 2025
Merged
Fix indentation in generated step definition classes#144304NotModified merged 4 commits intosupport-file-scoped-namespacesfrom
304NotModified merged 4 commits intosupport-file-scoped-namespacesfrom
Conversation
6 tasks
Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add support for file scoped namespace declarations
Fix indentation in generated step definition classes
Dec 16, 2025
gasparnagy
added a commit
that referenced
this pull request
Jan 27, 2026
* Support csharp_style_namespace_declarations = file_scoped * Update CHANGELOG.md * extract GenerateStepDefinitionClass and add snapshot tests * Fix indentation in generated step definition classes (#144) * Initial plan * Fix indentation in generated step definition classes Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com> * Complete indentation fix - all checks passed Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com> * Remove accidentally committed nuget.exe binary Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com> * Remove nuget.exe from .gitignore Remove nuget.exe from .gitignore * Fix typo in CHANGELOG for namespace support * refactor * fix changelog * small cleanup * fix: load the editor config through the right project --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Gáspár Nagy <gaspar.nagy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated step definition classes had closing braces incorrectly concatenated on the same line, producing malformed code like
} }for block-scoped namespaces and}}for file-scoped namespaces.Root cause: The code generator used
StringBuilder.Append()instead ofAppendLine()when appending the step definition snippet, causing the class closing brace to appear on the same line as the method's closing brace.Changes:
DefineStepsCommand.cs: Changedtemplate.Append(adjustedSnippet)totemplate.AppendLine(adjustedSnippet)inGenerateStepDefinitionClass()Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.