Fix: Error message box when creating feature file with space in its name #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Fix: Error message box when creating feature file with space in its name
The "Add feature file" wizard has a special handling of feature files: it bypasses the standard VS "add" functionality and creates the file directly on disk. To simulate the VS "add" behavior it also opens the file after the add wizard has been finished. This is performed using
DTE.ExecuteCommand("File.OpenFile", <filepath>)command that does not seem to handle spaces in file name by default, you need to wrap the file name with double quotes. This wrapping has been added now.⚡️ What's your motivation?
Fixes #50
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Can only be tested manually. Tests have been performed.
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.