Enhance step completion with usage-based ordering #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

maciekpazola wants to merge 1 commit into reqnroll:main from maciekpazola:Idea#331-AddFavoriteSteps

Closed

Enhance step completion with usage-based ordering #56

Enhance step completion with usage-based ordering

Annotations

10 errors and 24 warnings

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L118

Reqnroll.ComparisonException : | item | - | there is a calculator | at Reqnroll.Assist.SetComparer`1.ThrowAnErrorDetailingWhichItemsAreMissing(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.AssertThatTheItemsMatchTheExpectedResults(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.CompareToSet(IEnumerable`1 set, Boolean sequentialEquality) at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.CheckCompletions(Table expectedItemsTable, Func`2 filter) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 927 at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.ThenACompletionListShouldPopUpWithTheFollowingItems(Table expectedItemsTable) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 905 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Reqnroll.Bindings.BindingInvoker.<InvokeBindingAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepMatchAsync>d__59.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepAsync>d__56.MoveNext() at Reqnroll.Infrastructure.TestExecutionEngine.<OnAfterLastStepAsync>d__38.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.TestRunner.<CollectScenarioErrorsAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<ScenarioCleanupAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<FiltersCompletionList>d__19.MoveNext() in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\Features\Editor\StepCompletion.feature:line 118 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L118

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L44

Expected completionSet not to be <null> because There should be an active completion set. at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message) at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc) at FluentAssertions.Primitives.ReferenceTypeAssertions`2.NotBeNull(String because, Object[] becauseArgs) at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.WhenCommitTheCompletionItem(String value) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 533 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Reqnroll.Bindings.BindingInvoker.<InvokeBindingAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepMatchAsync>d__59.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepAsync>d__56.MoveNext() at Reqnroll.Infrastructure.TestExecutionEngine.<OnAfterLastStepAsync>d__38.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.TestRunner.<CollectScenarioErrorsAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<ScenarioCleanupAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<CompletesStepAtTheCaretPosition>d__15.MoveNext() in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\Features\Editor\StepCompletion.feature:line 44 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L82

Reqnroll.ComparisonException : | item | - | I have entered [int] into the "[string]" calculator | at Reqnroll.Assist.SetComparer`1.ThrowAnErrorDetailingWhichItemsAreMissing(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.AssertThatTheItemsMatchTheExpectedResults(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.CompareToSet(IEnumerable`1 set, Boolean sequentialEquality) at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.CheckCompletions(Table expectedItemsTable, Func`2 filter) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 927 at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.ThenACompletionListShouldPopUpWithTheFollowingItems(Table expectedItemsTable) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 905 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Reqnroll.Bindings.BindingInvoker.<InvokeBindingAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepMatchAsync>d__59.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepAsync>d__56.MoveNext() at Reqnroll.Infrastructure.TestExecutionEngine.<OnAfterLastStepAsync>d__38.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.TestRunner.<CollectScenarioErrorsAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<ScenarioCleanupAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<OffersSimpleStepDefinitionsWithParameterPlaceholders>d__17.MoveNext() in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\Features\Editor\StepCompletion.feature:line 82 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L99

Reqnroll.ComparisonException : | item | - | I use a (?:[step]+) with (\d+) parameter | at Reqnroll.Assist.SetComparer`1.ThrowAnErrorDetailingWhichItemsAreMissing(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.AssertThatTheItemsMatchTheExpectedResults(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.CompareToSet(IEnumerable`1 set, Boolean sequentialEquality) at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.CheckCompletions(Table expectedItemsTable, Func`2 filter) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 927 at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.ThenACompletionListShouldPopUpWithTheFollowingItems(Table expectedItemsTable) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 905 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Reqnroll.Bindings.BindingInvoker.<InvokeBindingAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepMatchAsync>d__59.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepAsync>d__56.MoveNext() at Reqnroll.Infrastructure.TestExecutionEngine.<OnAfterLastStepAsync>d__38.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.TestRunner.<CollectScenarioErrorsAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<ScenarioCleanupAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<OffersComplexStepDefinitionsAsRegex>d__18.MoveNext() in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\Features\Editor\StepCompletion.feature:line 99 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Tests/Reqnroll.VisualStudio.Specs/Features/Editor/StepCompletion.feature#L14

Reqnroll.ComparisonException : | item | - | I press add | at Reqnroll.Assist.SetComparer`1.ThrowAnErrorDetailingWhichItemsAreMissing(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.AssertThatTheItemsMatchTheExpectedResults(IEnumerable`1 listOfMissingItems) at Reqnroll.Assist.SetComparer`1.CompareToSet(IEnumerable`1 set, Boolean sequentialEquality) at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.CheckCompletions(Table expectedItemsTable, Func`2 filter) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 927 at Reqnroll.VisualStudio.Specs.StepDefinitions.ProjectSystemSteps.ThenACompletionListShouldPopUpWithTheFollowingItems(Table expectedItemsTable) in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\StepDefinitions\ProjectSystemSteps.cs:line 905 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at Reqnroll.Bindings.BindingInvoker.<InvokeBindingAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepMatchAsync>d__59.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.Infrastructure.TestExecutionEngine.<ExecuteStepAsync>d__56.MoveNext() at Reqnroll.Infrastructure.TestExecutionEngine.<OnAfterLastStepAsync>d__38.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Reqnroll.TestRunner.<CollectScenarioErrorsAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<ScenarioCleanupAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at Reqnroll.VisualStudio.Specs.Features.Editor.StepCompletionFeature.<OffersStepDefinitionsOfTheScenarioBlockAtTheCaret>d__13.MoveNext() in D:\a\Reqnroll.VisualStudio\Reqnroll.VisualStudio\Tests\Reqnroll.VisualStudio.Specs\Features\Editor\StepCompletion.feature:line 14 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

The target framework 'net7.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

Connectors/Reqnroll.VisualStudio.ReqnrollConnector/Discovery/NoInvokeDependencyProvider.cs#L14