Convert to NSubstitute #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@reqnroll/core-team could I get a review of this? I know its not high priority, but I don't like if this get stale. Most of the changes are "replaced all". If you doubt if parts works the same, feel free to ask. Or ask github copilot:) |
clrudolphi
requested changes
May 2, 2025
Contributor
clrudolphi
left a comment
clrudolphi
left a comment
There was a problem hiding this comment.
Looking for a few points of clarification.
clrudolphi
approved these changes
Jul 7, 2025
Contributor
clrudolphi
left a comment
clrudolphi
left a comment
There was a problem hiding this comment.
Overall LGTM.
On my machine, none of the Reqnroll.VisualStudio.Specs.Features.Dicovery tests work. They all complain about 'Test assembly not found.' errors. But that problem is also true from the main branch as well, so I don't think it has anything to do with NSubstitute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
https://github.com/orgs/reqnroll/discussions/478#discussioncomment-12314895
🏷️ What kind of change is this?