Skip to content

Prefix generated regexes with a caret (^) to ensure they are not interpreted as Cucumber expressions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
304NotModified wants to merge 3 commits into from
Closed

Prefix generated regexes with a caret (^) to ensure they are not interpreted as Cucumber expressions #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f75cb2
Prefix generated Regex
304NotModified Jul 4, 2025
29612fb
changelog
304NotModified Jul 4, 2025
e6970ad
Merge branch 'main' into prefix-regex
304NotModified Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

## Improvements:

* Generated regexes are prefixed with a caret (`^`) to ensure they are not interpreted as Cucumber expressions. (#98)

## Bug fixes:

* Fix: Ambiguous steps reported wehn definition matches via more than one tag (#95)
*Contributors of this release (in alphabetical order):* @clrudolphi

*Contributors of this release (in alphabetical order):* @304NotModified, @clrudolphi

# v2025.1.256 - 2025-03-07

Expand Down
3 changes: 2 additions & 1 deletion Reqnroll.VisualStudio/Snippets/Fallback/RegexStepDefinitionSkeletonProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ public RegexStepDefinitionSkeletonProvider(ReqnrollProjectTraits projectTraits)

protected override string GetExpression(AnalyzedStepText stepText)
{
StringBuilder result = new StringBuilder();
// Prefix regex with ^ to ensure that it's detected as regex instead of a cucumber expression.
StringBuilder result = new StringBuilder("^");

result.Append(EscapeRegex(stepText.TextParts[0]));
for (int i = 1; i < stepText.TextParts.Count; i++)
Expand Down
4 changes: 2 additions & 2 deletions Tests/Reqnroll.VisualStudio.Specs/Features/Editor/Commands/DefineStepsCommand.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Scenario: DefineSteps command abides by reqnroll.json configuration for regex sk
When I invoke the "Define Steps" command
Then the define steps dialog should be opened with the following step definition skeletons
| type | expression |
| Given | the client added (.*) pcs to the basket |
| Given | ^the client added (.*) pcs to the basket |

Scenario: DefineSteps command properly escapes empty brackets when using Cucumber expressions
Given there is a Reqnroll project scope
Expand Down Expand Up @@ -161,5 +161,5 @@ Scenario: DefineSteps command properly escapes empty brackets when using Regex e
When I invoke the "Define Steps" command
Then the define steps dialog should be opened with the following step definition skeletons
| type | expression |
| When | I use \\(parenthesis\), \\{curly braces}, \\\ backslash, and/or \\. period |
| When | ^I use \\(parenthesis\), \\{curly braces}, \\\ backslash, and/or \\. period |

Loading