Fix1013 ms testv4 disable friendly names doesnt work #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.3.2 generates a callerLineNumber attribute into the constructor call of the TestMethod attribute. This caused an interaction bug with the V2 base class which assumed that the first item in the list of arguments was the display name. Fixed by specifically searching the argument list for the item that is the DisplayName property. This further exposed that the V2/V3 generator assumed that the display name was constructor argument, not a Property. The V4 generator had no unit tests, so refactored the V2 tests to run the same suite for both versions.
…ame from the TestMethod attribute declaration.
gasparnagy
deleted the
Fix1013_MsTestv4_disableFriendlyNames_doesnt_work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
V3.3.2 modified how we emit source line information for MsTestv4 by adding an argument value to the list of arguments provided to the
TestMethodattribute. This inadvertently interfered with the mechanism we were using to obtain the friendly DisplayName property value from the attribute.Investigation also uncovered that the MsTestV4GeneratorProvider was released without covering tests. Had we had them, this problem would have been uncovered at the time we added that class.
Tests for the MsTest GeneratorProvider have been updated to include testing the v4 generator provider.
⚡️ What's your motivation?
Fixes #1013
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.