Add overridable timeout values to FormattersBase#1029
Closed
clrudolphi wants to merge 1 commit intomainfrom
Closed
Add overridable timeout values to FormattersBase#1029clrudolphi wants to merge 1 commit intomainfrom
clrudolphi wants to merge 1 commit intomainfrom
Conversation
…the timeout values to use during Formatter disposal. These were previously hard-coded. This allows derivative formatters to set their own time-out values. The first real use of this is in the runtime tests in which the timeout values are set very small to allow those tests to complete much more quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Added two virtual properties to the FormattersBase class that provide the timeout values to use during Formatter disposal. These were previously hard-coded.
⚡️ What's your motivation?
This allows derivative formatters to set their own time-out values. The first real use of this is in the runtime tests in which the timeout values are set very small to allow those tests to complete much more quickly.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.