Skip to content

Add overridable timeout values to FormattersBase#1029

Closed
clrudolphi wants to merge 1 commit intomainfrom
RefactorFormatters_to_Support_Customizable_Timeouts
Closed

Add overridable timeout values to FormattersBase#1029
clrudolphi wants to merge 1 commit intomainfrom
RefactorFormatters_to_Support_Customizable_Timeouts

Conversation

@clrudolphi
Copy link
Copy Markdown
Contributor

🤔 What's changed?

Added two virtual properties to the FormattersBase class that provide the timeout values to use during Formatter disposal. These were previously hard-coded.

⚡️ What's your motivation?

This allows derivative formatters to set their own time-out values. The first real use of this is in the runtime tests in which the timeout values are set very small to allow those tests to complete much more quickly.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

…the timeout values to use during Formatter disposal. These were previously hard-coded.

This allows derivative formatters to set their own time-out values. The first real use of this is in the runtime tests in which the timeout values are set very small to allow those tests to complete much more quickly.
@clrudolphi clrudolphi marked this pull request as ready for review February 10, 2026 14:41
@clrudolphi clrudolphi closed this Feb 13, 2026
@clrudolphi clrudolphi deleted the RefactorFormatters_to_Support_Customizable_Timeouts branch February 13, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant