Skip to content

Conversation

@304NotModified
Copy link
Member

@304NotModified 304NotModified commented Sep 17, 2025

🤔 What's changed?

  • Added readmes to all NuGet packages, with the help of Copilot. I reviewed all the readmes and edited most of them.
  • Added XML docs to the NuGet packages
  • Added NoWarn for "Missing XML comment for publicly visible type or member" (CS1591), otherwise there are many warnings.
  • Removed old <summary> from xunit3 package (was already removed for others) - see Removed deprecated <summary> from NuGet packages #766

See also validation results, the warning for the reqnroll pacakge is fine (will disable in the future)

image image

The Verify package has still some issues, that is out of scope here, see #709

image

⚡️ What's your motivation?

Better documentation

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

📋 Checklist:

  • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

Copilot AI and others added 7 commits August 16, 2025 22:07
…nroll.Generator, Reqnroll.Utils, Reqnroll.Tools.MsBuild.Generation

Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…nit, xUnit, TUnit

Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…, DI, ExternalData, Verify, SpecFlowCompatibility, CustomPlugin, Templates

Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…pdate links, change bash to powershell

Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
@304NotModified 304NotModified added the documentation Improvements or additions to documentation label Sep 17, 2025
@304NotModified 304NotModified changed the title Add README files and enable XML documentation for all NuGet packages Add READMEs and enable XML documentation to all NuGet packages Sep 17, 2025
@304NotModified 304NotModified changed the title Add READMEs and enable XML documentation to all NuGet packages Add READMEs and XML documentation to all NuGet packages Sep 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds comprehensive documentation by including README files and enabling XML documentation generation for all NuGet packages in the Reqnroll project.

  • Adds README.md files to 20+ NuGet packages with concise descriptions and usage information
  • Enables XML documentation generation (GenerateDocumentationFile) for better API documentation
  • Updates package configuration to include README files in NuGet packages

Reviewed Changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Templates/Reqnroll.Templates.DotNet/* Adds README and package configuration for dotnet templates
Reqnroll/Reqnroll.nuspec Updates README file reference from PackageReadme.md to README.md
Reqnroll.Utils/* Adds README and XML documentation configuration
Reqnroll.Tools.MsBuild.Generation/* Adds README and XML documentation for MSBuild generation tools
Reqnroll.Parser/* Adds README and XML documentation for Gherkin parser
Reqnroll.Generator/* Adds README and XML documentation for code generator
Plugins/*/README.md Adds READMEs for all plugin packages (xUnit, Windsor, Verify, TUnit, SpecFlow compatibility, NUnit, Microsoft DI, MSTest, ExternalData, CustomPlugin, Autofac)
Plugins//.csproj Enables XML documentation generation for plugin projects
Plugins//.nuspec Updates package specifications to include README files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@304NotModified
Copy link
Member Author

@gasparnagy It would be nice if we could include this for 3.1 :)

@304NotModified 304NotModified force-pushed the package-readmes branch 2 times, most recently from 1ee3381 to 1783253 Compare September 17, 2025 23:12
<file src="build\**\*" exclude="build\*.template.*" target="build" />
<file src="bin\$config$\netstandard2.0\Reqnroll.xUnit.ReqnrollPlugin.*" target="lib\netstandard2.0" />
<file src="bin\$config$\net462\Reqnroll.xUnit.ReqnrollPlugin.*" target="lib\net462" />
<file src="bin\$config$\netstandard2.0\Reqnroll.xUnit.ReqnrollPlugin.dll" target="lib\netstandard2.0" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO double check with current package on nuget

@304NotModified 304NotModified marked this pull request as ready for review September 17, 2025 23:37
@gasparnagy
Copy link
Contributor

@gasparnagy It would be nice if we could include this for 3.1 :)

Would be great. But let's wait for #812 to be finished first.

@gasparnagy
Copy link
Contributor

@304NotModified #812 is merged. Do you see a chance you can update this until the end of this week?

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I have checked the first few readme, but they require more work. I will continue later.

@@ -0,0 +1,9 @@
Reqnroll.CustomPlugin provides a sample custom plugin for Reqnroll.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "Reqnroll.CustomPlugin provides the required dependencied for writing custom Reqnroll generator extensions."


## Support

- [Reqnroll Documentation](https://docs.reqnroll.net/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Support

- [Reqnroll Documentation](https://docs.reqnroll.net/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,13 @@
Reqnroll.Microsoft.Extensions.DependencyInjection provides [Microsoft.Extensions.DependencyInjection](https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection-usage) integration for Reqnroll.

This package enables Reqnroll to use the standard .NET dependency injection container for resolving step definitions, hooks, and other dependencies in your BDD tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"standard .NET dependency injection container": I wouldn't call it "standard" (despite what MS thinks). I would say "This package enables Reqnroll to dependency injection container from the Microsoft.Extensions.DependencyInjection package for ..."


## Support

- [Reqnroll Documentation](https://docs.reqnroll.net/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@304NotModified 304NotModified marked this pull request as draft October 8, 2025 22:48
@304NotModified 304NotModified added the parked We decided to delay dealing with this label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation parked We decided to delay dealing with this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants