-
Notifications
You must be signed in to change notification settings - Fork 108
Add READMEs and XML documentation to all NuGet packages #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nroll.Generator, Reqnroll.Utils, Reqnroll.Tools.MsBuild.Generation Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…nit, xUnit, TUnit Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…, DI, ExternalData, Verify, SpecFlowCompatibility, CustomPlugin, Templates Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
…pdate links, change bash to powershell Co-authored-by: 304NotModified <5808377+304NotModified@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds comprehensive documentation by including README files and enabling XML documentation generation for all NuGet packages in the Reqnroll project.
- Adds README.md files to 20+ NuGet packages with concise descriptions and usage information
- Enables XML documentation generation (
GenerateDocumentationFile) for better API documentation - Updates package configuration to include README files in NuGet packages
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Templates/Reqnroll.Templates.DotNet/* | Adds README and package configuration for dotnet templates |
| Reqnroll/Reqnroll.nuspec | Updates README file reference from PackageReadme.md to README.md |
| Reqnroll.Utils/* | Adds README and XML documentation configuration |
| Reqnroll.Tools.MsBuild.Generation/* | Adds README and XML documentation for MSBuild generation tools |
| Reqnroll.Parser/* | Adds README and XML documentation for Gherkin parser |
| Reqnroll.Generator/* | Adds README and XML documentation for code generator |
| Plugins/*/README.md | Adds READMEs for all plugin packages (xUnit, Windsor, Verify, TUnit, SpecFlow compatibility, NUnit, Microsoft DI, MSTest, ExternalData, CustomPlugin, Autofac) |
| Plugins//.csproj | Enables XML documentation generation for plugin projects |
| Plugins//.nuspec | Updates package specifications to include README files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bec5177 to
b4f0512
Compare
|
@gasparnagy It would be nice if we could include this for 3.1 :) |
1ee3381 to
1783253
Compare
1783253 to
9735ae7
Compare
| <file src="build\**\*" exclude="build\*.template.*" target="build" /> | ||
| <file src="bin\$config$\netstandard2.0\Reqnroll.xUnit.ReqnrollPlugin.*" target="lib\netstandard2.0" /> | ||
| <file src="bin\$config$\net462\Reqnroll.xUnit.ReqnrollPlugin.*" target="lib\net462" /> | ||
| <file src="bin\$config$\netstandard2.0\Reqnroll.xUnit.ReqnrollPlugin.dll" target="lib\netstandard2.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO double check with current package on nuget
Would be great. But let's wait for #812 to be finished first. |
|
@304NotModified #812 is merged. Do you see a chance you can update this until the end of this week? |
gasparnagy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. I have checked the first few readme, but they require more work. I will continue later.
| @@ -0,0 +1,9 @@ | |||
| Reqnroll.CustomPlugin provides a sample custom plugin for Reqnroll. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "Reqnroll.CustomPlugin provides the required dependencied for writing custom Reqnroll generator extensions."
|
|
||
| ## Support | ||
|
|
||
| - [Reqnroll Documentation](https://docs.reqnroll.net/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| ## Support | ||
|
|
||
| - [Reqnroll Documentation](https://docs.reqnroll.net/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,13 @@ | |||
| Reqnroll.Microsoft.Extensions.DependencyInjection provides [Microsoft.Extensions.DependencyInjection](https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection-usage) integration for Reqnroll. | |||
|
|
|||
| This package enables Reqnroll to use the standard .NET dependency injection container for resolving step definitions, hooks, and other dependencies in your BDD tests. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"standard .NET dependency injection container": I wouldn't call it "standard" (despite what MS thinks). I would say "This package enables Reqnroll to dependency injection container from the Microsoft.Extensions.DependencyInjection package for ..."
|
|
||
| ## Support | ||
|
|
||
| - [Reqnroll Documentation](https://docs.reqnroll.net/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 What's changed?
<summary>from xunit3 package (was already removed for others) - see Removed deprecated<summary>from NuGet packages #766See also validation results, the warning for the reqnroll pacakge is fine (will disable in the future)
The Verify package has still some issues, that is out of scope here, see #709
⚡️ What's your motivation?
Better documentation
🏷️ What kind of change is this?
📋 Checklist: