Type hinting __aenter__ with Self#367
Merged
JWCook merged 3 commits intorequests-cache:mainfrom Sep 25, 2025
jamesbraza:typing-self
Merged
Type hinting __aenter__ with Self#367JWCook merged 3 commits intorequests-cache:mainfrom jamesbraza:typing-self
__aenter__ with Self#367JWCook merged 3 commits intorequests-cache:mainfrom
jamesbraza:typing-self
Conversation
CachedSession.__aenter__ with Self__aenter__ with Self
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 96.20% 95.89% -0.32%
==========================================
Files 10 10
Lines 1081 1096 +15
Branches 188 113 -75
==========================================
+ Hits 1040 1051 +11
- Misses 30 32 +2
- Partials 11 13 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
typing-extensions>=4for Python before 3.11 for theSelftype, too.Closes #352